Add timer to prevent over clicking of didn't receive a magic code button by NikkiWines · Pull Request #20732 · Expensify/App

NikkiWines · 2023-06-14T00:33:21Z

Details

Users occasionally end up throttling themselves by over clicking the Didn't receive a magic code button. This is a quick UI update that should hopefully discourage that so that users are less likely to temporarily block themselves. '

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/290805
PROPOSAL: N/A Internal

Tests

Try to log into an Expensify account on new Expensify
Confirm you get a notification with a magic code
Confirm you see a countdown for requesting a new magic code
Wait 30s until the countdown completes and request a new code when the view updates to the Didn't receive a magic code link
Confirm you get a notification with another magic code
Press the blue Go back link before the timer ends and re-enter your email
Confirm the timer has restarted on the magic code view and that you receive another magic code notification
Try to sign in without entering a code and confirm the timer has not restarted and that you see an appropriate error message
Try to sign in with the incorrect code and confirm the timer has not restarted and confirm you see an appropriate error message
Enter the correct code and confirm you can sign in successfully.

Verify that no errors appear in the JS console

Offline tests

Try to log into an Expensify account on new Expensify
Confirm you get a notification with a magic code
Confirm you see a countdown for requesting a new magic code
Go offline and confirm the UI updates to show the Didn't receive a magic code link and that it is disabled

QA Steps

Try to log into an Expensify account on new Expensify
Confirm you get a notification with a magic code
Confirm you see a countdown for requesting a new magic code
Wait 30s until the countdown completes and request a new code when the view updates to the Didn't receive a magic code link
Confirm you get a notification with another magic code
Press the blue Go back link before the timer ends and re-enter your email
Confirm the timer has restarted on the magic code view and that you receive another magic code notification
Try to sign in without entering a code and confirm the timer has not restarted and that you see an appropriate error message
Try to sign in with the incorrect code and confirm the timer has not restarted and confirm you see an appropriate error message
Enter the correct code and confirm you can sign in successfully.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

Screen.Recording.2023-06-13.at.20.38.52.mov

Mobile Web - Safari

mweb-safari.mp4

Desktop

desktop.mov

iOS

ios.mp4

Android

2023-06-14_14-54-47.mp4

…ate code

melvin-bot · 2023-06-15T01:59:12Z

@s77rt @roryabraham One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

minor style/comment adjustments

NikkiWines · 2023-06-15T18:17:26Z

thanks for the review @s77rt 🙇 updated!

s77rt · 2023-06-15T23:38:30Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mp4

Mobile Web - Chrome

mweb-chrome.mp4

Mobile Web - Safari

mweb-safari.mp4

Desktop

desktop.mp4

iOS

ios.mp4

Android

android.mp4

s77rt · 2023-06-15T23:38:53Z

Looks good but we have conflicts

…send-validate-code-timer

remove linkSent logic

…/Expensify/App into nikki-resend-validate-code-timer

NikkiWines · 2023-06-16T16:20:37Z

updated once more to resolve conflicts

s77rt · 2023-06-16T17:09:11Z

Retested. Working well 👍

s77rt

LGTM! 🚀

cc @roryabraham

melvin-bot · 2023-06-16T17:11:47Z

🎯 @s77rt, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #20914.

roryabraham

Oh, nevermind I see you're actually displaying a timer. My bad, going too quick here...

roryabraham · 2023-06-17T01:02:59Z

        textAlign: 'center',
    },
+
+    validateCodeTimer: {


Actually, this style is a duplicate of textBlue, so let's use that instead of introducing a new one. There is this checklist item:

If a new CSS style is added I verified that ... A similar style doesn't already exist

Oops that's on me. Thanks @roryabraham

Oops, I swear I looked for a matching style. Nice catch, @roryabraham!

NikkiWines · 2023-06-20T16:32:29Z

@s77rt @roryabraham updated 🙇

…idate-code-timer

NikkiWines · 2023-06-22T15:30:36Z

Friendly bump on reviewing here @s77rt @roryabraham

OSBotify · 2023-06-22T16:31:03Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-06-22T17:20:47Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 1.3.31-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

mountiny · 2023-06-23T11:29:51Z

 import Terms from '../Terms';
-import DotIndicatorMessage from '../../../components/DotIndicatorMessage';
 import PressableWithFeedback from '../../../components/Pressable/PressableWithFeedback';
 import usePrevious from '../../../hooks/usePrevious';


Coming from this issue #21390 this implementation causes that if you go back and sign in again with the same email new magic code is sent as the timer got reset. I think its just a polish or maybe its something we are intentionally happy with but noting here #21390

This is the expected behaviour

Press the blue Go back link before the timer ends and re-enter your email
Confirm the timer has restarted on the magic code view and that you receive another magic code notification

OSBotify · 2023-06-23T21:05:28Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.31-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-06-23T21:25:13Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.31-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Pujan92 · 2023-06-26T09:51:31Z

@NikkiWines Seems a regression #21545 from this PR where an error display part has been moved.

s77rt · 2023-06-26T13:09:51Z

Oh right, we missed that, the errors part was moved inside an if condition (covering only one case) where it used to cover two cases (outside the if condition).

@NikkiWines Can you draft a quick PR for this since I think this is within the regression period

NikkiWines · 2023-06-26T17:20:01Z

Ah, yep - I can spin up a fix today

NikkiWines added 3 commits June 13, 2023 19:08

add 30 second timer before allowing user to resend themselves a valid…

7435c2d

…ate code

add translations

80397fa

add/modify styles

36e7498

NikkiWines self-assigned this Jun 14, 2023

only show countdown if online

9777d7b

NikkiWines marked this pull request as ready for review June 15, 2023 01:58

NikkiWines requested a review from a team as a code owner June 15, 2023 01:58

melvin-bot Bot requested review from roryabraham and s77rt and removed request for a team June 15, 2023 01:59

NikkiWines added 2 commits June 14, 2023 22:03

simplify set timer logic

2892933

prettier style

fcf3946

s77rt suggested changes Jun 15, 2023

View reviewed changes

NikkiWines added 2 commits June 15, 2023 14:04

remove props.account.message usage

c47ee2e

use timeout instead of interval

b79a8ad

minor style/comment adjustments

NikkiWines added 4 commits June 16, 2023 12:03

Merge branch 'main' of https://github.com/Expensify/App into nikki-re…

ccd2b3a

…send-validate-code-timer

merge main to baseValidateCodeForm

3175889

remove linkSent logic

prettier style

fcaa868

Merge branch 'nikki-resend-validate-code-timer' of https://github.com…

f96bade

…/Expensify/App into nikki-resend-validate-code-timer

s77rt approved these changes Jun 16, 2023

View reviewed changes

melvin-bot Bot mentioned this pull request Jun 16, 2023

Payment issue for E/App PR#20732 #20914

Closed

roryabraham requested changes Jun 17, 2023

View reviewed changes

Comment thread src/pages/signin/ValidateCodeForm/BaseValidateCodeForm.js

roryabraham approved these changes Jun 17, 2023

View reviewed changes

roryabraham requested changes Jun 17, 2023

View reviewed changes

remove duplicated css style

c9a3f1a

Merge branch 'main' of github.com:Expensify/App into nikki-resend-val…

cb78277

…idate-code-timer

roryabraham approved these changes Jun 22, 2023

View reviewed changes

roryabraham merged commit 692a1a3 into main Jun 22, 2023

roryabraham deleted the nikki-resend-validate-code-timer branch June 22, 2023 16:26

OSBotify mentioned this pull request Jun 22, 2023

Deploy Checklist: New Expensify 2023-06-22 #21330

Closed

39 tasks

NikkiWines mentioned this pull request Jun 23, 2023

[HOLD for payment 2023-07-13] Web - Unresponsive 'request a code here' link on 'Magic code expired' page #21351

Closed

6 tasks

mountiny reviewed Jun 23, 2023

View reviewed changes

s77rt mentioned this pull request Jun 23, 2023

[$1000] Login- A user can bypass the request a new magic code time limit by clicking the " go back" button and then clicking continue in the sign in page and clicking #21390

Closed

6 tasks

This was referenced Jun 26, 2023

Display error beneath magic code input field for 2FA #21595

Merged

[$1000] [HOLD for payment 2023-07-05] Login - No error message when incorrect 2FA code is entered #21545

Closed

sobitneupane mentioned this pull request Aug 9, 2023

[HOLD for payment 2023-08-02] [$1000] Web - Clicking next to 'Didn't receive a magic code?' link requests a code on sign-in page, but it doesn't on contact methods section #22935

Closed

6 tasks

Conversation

NikkiWines commented Jun 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jun 15, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

NikkiWines commented Jun 15, 2023

Uh oh!

s77rt commented Jun 15, 2023

Reviewer Checklist

Screenshots/Videos

Uh oh!

s77rt commented Jun 15, 2023

Uh oh!

NikkiWines commented Jun 16, 2023

Uh oh!

s77rt commented Jun 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

s77rt left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented Jun 16, 2023

Uh oh!

Uh oh!

roryabraham left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

roryabraham Jun 17, 2023

Choose a reason for hiding this comment

Uh oh!

s77rt Jun 17, 2023

Choose a reason for hiding this comment

Uh oh!

NikkiWines Jun 20, 2023

Choose a reason for hiding this comment

Uh oh!

NikkiWines commented Jun 20, 2023

Uh oh!

NikkiWines commented Jun 22, 2023

Uh oh!

OSBotify commented Jun 22, 2023

Uh oh!

OSBotify commented Jun 22, 2023

Uh oh!

mountiny Jun 23, 2023

Choose a reason for hiding this comment

Uh oh!

s77rt Jun 23, 2023

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Jun 23, 2023

Uh oh!

OSBotify commented Jun 23, 2023

Uh oh!

Pujan92 commented Jun 26, 2023

Uh oh!

s77rt commented Jun 26, 2023

Uh oh!

NikkiWines commented Jun 26, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

NikkiWines commented Jun 14, 2023 •

edited

Loading

s77rt commented Jun 16, 2023 •

edited

Loading

roryabraham left a comment •

edited

Loading