[$1000] [HOLD for payment 2023-07-05] Login - No error message when incorrect 2FA code is entered

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Launch New Expensify app
2. Enter email with 2FA enabled
3. Enter magic code
4. Enter incorrect 2FA code

Expected Result:

Error message shows up

Actual Result:

No error message shows up

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.32.5

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6105863_Screen_Recording_20230626_005930_New_Expensify.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0143a8a604702d17da
• Upwork Job ID: 1677391541161357312
• Last Price Increase: 2023-07-07

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[allroundexperts]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Error message not shown when entering an incorrect 2FA code in the Sign in form.

What is the root cause of that problem?

The root cause of the issue is that after this PR, we did not show the server error message for the MagicCodeInput here.

What changes do you think we should make in order to solve the problem?

We need to add the following here:

 {hasError && <FormHelpMessage message={ErrorUtils.getLatestErrorMessage(props.account)} />}

What alternative solutions did you explore? (Optional)

N/A

[NikkiWines]

This is a regression of #20732 - PR to fix it is here

[johncschuster]

Sweet! Thanks for linking the issue, @NikkiWines!