[HOLD for payment 2023-08-02] [$1000] Web - Clicking next to 'Didn't receive a magic code?' link requests a code on sign-in page, but it doesn't on contact methods section

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Navigate to sign-in page
2. Enter email & click on 'Continue' button
3. Wait for timeout to finish
4. Hover over the blank space next to 'Didn't receive a magic code?' link & click on the empty space

Expected Result:

The empty space next to the link shouldn't be clickable as it doesn't on the contact methods section

Actual Result:

The empty space next to the link is clickable

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.40-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screencast.from.2023-07-14.15-55-32.mp4

Recording.3655.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Natnael-Guchima
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689339820759009

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d234fa38b658c551
• Upwork Job ID: 1681240927406481408
• Last Price Increase: 2023-07-18

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[namhihi237]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The empty space next to the link shouldn't be clickable as it doesn't on the contact methods section

What is the root cause of that problem?

In the login page we can click to the right of the text because it takes full width with parent element

App/src/pages/signin/ValidateCodeForm/BaseValidateCodeForm.js

Lines 286 to 293 in b9508b6

	<View>
	{timeRemaining > 0 && !props.network.isOffline ? (
	<Text style={[styles.mt2]}>
	{props.translate('validateCodeForm.requestNewCode')}
	<Text style={[styles.textBlue]}>00:{String(timeRemaining).padStart(2, '0')}</Text>
	</Text>
	) : (
	<PressableWithFeedback

At contract validate screen we have style styles.alignItemsStart

App/src/pages/settings/Profile/Contacts/ValidateCodeForm/BaseValidateCodeForm.js

Lines 147 to 149 in b9508b6

	<View style={[styles.mt2, styles.dFlex, styles.flexColumn, styles.alignItemsStart]}>
	<PressableWithFeedback
	disabled={props.network.isOffline}

What changes do you think we should make in order to solve the problem?

It's easy to see the difference here, I think in the login screen we should just be able to click on the text "Didn't receive a magic code?" like "go back" .
So we should add style styles.alignItemsStart here

What alternative solutions did you explore? (Optional)

N/A

[ahmdshrif]

Proposal

Please restate the problem that we are trying to solve in this issue.

Clicking next to "Didn't receive a magic code?" should trigger the link.

What is the root cause of that problem?

By default, we set align-self or align-items on the parent to stretch, causing the PressableWithFeedback component to take the parent's width.

What changes do you think we should make to solve the problem?

We need to add self-alignment to start or baseline the style of PressableWithFeedback here:

App/src/pages/signin/ValidateCodeForm/BaseValidateCodeForm.js

Lines 286 to 295 in b9508b6

	<View>
	{timeRemaining > 0 && !props.network.isOffline ? (
	<Text style={[styles.mt2]}>
	{props.translate('validateCodeForm.requestNewCode')}
	<Text style={[styles.textBlue]}>00:{String(timeRemaining).padStart(2, '0')}</Text>
	</Text>
	) : (
	<PressableWithFeedback
	style={[styles.mt2]}
	onPress={resendValidateCode}

 style={[styles.mt2, styles.alignSelfStart]}

What alternative solutions did you explore? (Optional)

We can add styles.alignItemsStart to the main parent view, but this will affect the behavior of other children. Therefore, I prefer to keep the parent's default behavior and apply alignSelfStart to the PressableWithFeedback component.

Result:-

Screen.Recording.2023-07-15.at.7.35.05.PM.mov

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d234fa38b658c551

[melvin-bot]

Current assignee @laurenreidexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)