LIMS-1436: Use auth provider provided logout URL when SSO is enabled#822
Merged
ndg63276 merged 3 commits intoSep 3, 2024
Merged
Conversation
ndg63276
added a commit
that referenced
this pull request
Sep 17, 2024
* LIMS-1432: Add shelxt downstream view (#818) * LIMS-1436: Use auth provider provided logout URL when SSO is enabled (#822) * LIMS-1108: Improve message re international shipping (#721) * LIMS-1396: Use shipping service callback URL to only send emails once shipment is booked (#814) * LIMS-1435: Put CCP4 location into config variable (#821) * LIMS-656: Show auto subsamples if they have data (#817) --------- Co-authored-by: Dean Keeble <dean.keeble@diamond.ac.uk> Co-authored-by: Guilherme Francisco <guilherme.de-freitas@diamond.ac.uk> Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA ticket: LIMS-1436
Summary:
In order to make the authentication controllers truly generic, the logout URL must be provided by the upstream SSO authentication provider, to which logout attempts must be redirected to.
Changes:
To test:
cas_ssoinconfig.phptotrue, setauthentication_typetooidc, Log in, click the log out button, ensure you're redirected to CAScas_ssoinconfig.phptotrue, setauthentication_typetocombined, Log in, click the log out button, ensure you're redirected to CAScas_ssoinconfig.phptofalse, setauthentication_typetodummy, ensure you're not redirected to CAS when logging out