LIMS-656: Show auto subsamples if they have data#817
Merged
ndg63276 merged 4 commits intoSep 3, 2024
Merged
Conversation
Collaborator
|
Well 1 seems to have one extra subsample (10 items are shown in the list), is that because new data was inserted since this ticket was created? As an aside, clicking the "view collected data" button on a subsample, then clicking the permalink button, leads to an oddly placed modal being present, although this has no effect on the changes presented in this ticket. |
Collaborator
Author
Sorry, I didn't word it very well. Well 1 should have 10 items before and after this change. Well 169 should have 5 items before, and 9 items after this change. |
gfrn
approved these changes
Aug 28, 2024
…uto-subsamples-if-they-have-data
ndg63276
added a commit
that referenced
this pull request
Sep 17, 2024
* LIMS-1432: Add shelxt downstream view (#818) * LIMS-1436: Use auth provider provided logout URL when SSO is enabled (#822) * LIMS-1108: Improve message re international shipping (#721) * LIMS-1396: Use shipping service callback URL to only send emails once shipment is booked (#814) * LIMS-1435: Put CCP4 location into config variable (#821) * LIMS-656: Show auto subsamples if they have data (#817) --------- Co-authored-by: Dean Keeble <dean.keeble@diamond.ac.uk> Co-authored-by: Guilherme Francisco <guilherme.de-freitas@diamond.ac.uk> Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA ticket: LIMS-656
Summary:
If a subsample on a plate has an associated data collection, then it should always be shown, even if it is from an old inspection.
Changes:
To test:
Go to /containers/cid/249257 and click on the bottom left most well (well 169). There should be (at time of writing) 4 extra subsamples in the list under "Marked Subsamples", the first has X=2286, Y=716 and corresponds to /dc/visit/nt30330-87/id/10216910
Check well 1 on the same plate, there should be no difference in the number of subsamples shown as none have any data