[C-1856] Upgrade react-native to 0.71 by dylanjeffers · Pull Request #2644 · AudiusProject/audius-client

dylanjeffers · 2023-01-20T17:51:06Z

Description

Upgrades react-native to newly released 0.71. With this comes an awesome new flex-gap property, that should simplify our styling dev, so we aren't having to put "margin-bottom/top" on every child element.

Dragons

Since it is a project-wide change, we should make sure everything continues to to work as expected.
The amount of changes feels wrong, so going to look into package-lock changes
-- just tried removing lock and node_mods, and got same thing, so i think this is due to core deps changing

Lets wait to merge until monday, so this isn't included in release branch

How Has This Been Tested?

Tested android and ios

gitguardian · 2023-01-20T22:32:41Z

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	Secret	Commit	Filename
688750	Generic High Entropy Secret	`cfd62cb`	packages/mobile/.env.stage	View secret
2416684	Generic High Entropy Secret	`cfd62cb`	packages/mobile/.env.stage	View secret
688750	Generic High Entropy Secret	`cfd62cb`	packages/web/.env/.env.stage	View secret
2416684	Generic High Entropy Secret	`cfd62cb`	packages/web/.env/.env.stage	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secrets safely. Learn here the best practices.
Revoke and rotate these secrets.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!}

sliptype · 2023-01-20T23:02:37Z

    "@babel/plugin-transform-react-jsx": "7.16.7",
-    "@babel/runtime": "7.15.4",
-    "@react-native-community/eslint-config": "0.0.5",
+    "@babel/runtime": "^7.20.0",


sliptype · 2023-01-20T23:03:02Z

+     }
+
+     android.applicationVariants.all { variant ->
+        // skip debug build variant


Why is this patch needed?

microsoft/react-native-code-push#2418

[ef02ac1] Fix podfile, specify ruby-version (#2924) Dylan Jeffers [c925cfe] Fix track play button (#2925) Michael Piazza [6e3338b] [C-2201] Improve card list skeleton count (#2916) Dylan Jeffers [c696519] [C-2207] Fix scrubber timestamp sync issues (#2912) Dylan Jeffers [f9f5066] [C-2202] Sync legacy search history (#2915) Dylan Jeffers [1c50935] [C-2193] Fix webview audio players on ios (#2922) Raymond Jacobson [dd649d5] [C-1922] Fix mobile share encoding (#2918) Dylan Jeffers [eb6b89e] Fix collectibles route (#2917) Dylan Jeffers [efaa539] Fix lineup showing empty tile before fetch (#2911) Dylan Jeffers [c77076a] comma (#2920) Marcus Pasell [6041a40] [PAY-943] - Filter out download options for gated track (#2919) Saliou Diallo [3b2ff6d] [DMs] RadioButton component and InboxSettingsModal (#2884) Marcus Pasell [709dde5] [PAY-890] Add locked content modal (#2893) Saliou Diallo [3d8912f] [C-1856] Upgrade react-native to 0.71 (#2644) Dylan Jeffers [e863756] [C-1931] Refactor collection header for private track logic (#2676) Dylan Jeffers [1f8358b] [C-2171] Fix remove download performance (#2903) Dylan Jeffers [4050a55] [C-2042] Fix empty collection on deep link (#2914) Sebastian Klingler [03a31ee] [C-2164] add retry and requeue logic to download track jobs (#2899) Andrew Mendelsohn [3bf27f7] [C-2186] Fix spacing for longs handles/names (#2908) Raymond Jacobson [a89b3bb] Fix image loading issues w Share to X (#2909) nicoback2 [902159c] [C-2130] Fix race cond in lineup init (#2905) Raymond Jacobson [7beb57d] [C-2200] Fix profile tabs loading/empty states (#2906) Dylan Jeffers [6beaa2d] [C-2198] Fix runtime error due to missing drawer data (#2904) Dylan Jeffers [2b44b26] [C-2197] Fix image prefetch to work with fast-image (#2902) Dylan Jeffers [5a8069f] Permission copy change (#2901) nicoback2 [d427d3e] Fix TikTok share permission for iOS (#2897) nicoback2 [44c665d] [C-2195] Fix tiktok share on android (#2900) Sebastian Klingler [0235af9] [C-2178] Complete w/ tiktok qa fixes (#2896) Sebastian Klingler [dfe4622] Add repost of a repost metadata to reposting tracks and collections (#2847) sabrina-kiam [c2f6ad7] Minor updates to mobile chats (#2891) Reed [0e70d27] [C-2169] Fix track-player hot reload (#2890) Dylan Jeffers [a07ce78] Rename TikTok video feature flag (#2894) nicoback2 [3da2b87] Relay to both POA and ACDC (#2895) Isaac Solo [a02fee7] [C-2176] TikTok sdk improvements (#2892) Sebastian Klingler

[C-1856] Upgrade react-native to 0.71

c5eecbc

pull-request-size Bot added the size/XXL label Jan 20, 2023

dylanjeffers requested review from a team and amendelsohn and removed request for a team January 20, 2023 17:51

dylanjeffers added 7 commits January 20, 2023 10:15

Fix codepush patch

1f18663

Revert lock

610e02e

update lock?

f0ba373

Try again

5c5ab85

Remove react-native patch

1974638

Update typescript/lint

12ca449

Merge branch 'main' into dj-c-1856-react-native-0.71

cfd62cb

sliptype approved these changes Jan 20, 2023

View reviewed changes

dylanjeffers added 7 commits February 22, 2023 21:04

Update some more deps

edec585

Merge branch 'main' into dj-c-1856-react-native-0.71

220c2d9

Revert dem locks

c92207c

Final updates

54c78b8

Fix timeout type

839c342

Patch react native

5eca200

Go to 0.73

aa249c0

dylanjeffers merged commit 3d8912f into main Feb 23, 2023

dylanjeffers deleted the dj-c-1856-react-native-0.71 branch February 23, 2023 07:50

AudiusProject deleted a comment from linear Bot Sep 11, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[C-1856] Upgrade react-native to 0.71#2644

[C-1856] Upgrade react-native to 0.71#2644
dylanjeffers merged 15 commits into
mainfrom
dj-c-1856-react-native-0.71

dylanjeffers commented Jan 20, 2023 •

edited

Loading

Uh oh!

gitguardian Bot commented Jan 20, 2023 •

edited

Loading

Uh oh!

sliptype Jan 20, 2023

Uh oh!

sliptype Jan 20, 2023

Uh oh!

dylanjeffers Jan 20, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

dylanjeffers commented Jan 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Dragons

How Has This Been Tested?

Uh oh!

gitguardian Bot commented Jan 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Uh oh!

sliptype Jan 20, 2023

Choose a reason for hiding this comment

Uh oh!

sliptype Jan 20, 2023

Choose a reason for hiding this comment

Uh oh!

dylanjeffers Jan 20, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

dylanjeffers commented Jan 20, 2023 •

edited

Loading

gitguardian Bot commented Jan 20, 2023 •

edited

Loading