Skip to content
This repository was archived by the owner on Oct 4, 2023. It is now read-only.

[C-859] Omit is_verified from metadata that gets stored in user cache from fetchCID#1750

Merged
sliptype merged 3 commits into
mainfrom
sk-c-859-dont-read-verified-from-cn
Aug 18, 2022
Merged

[C-859] Omit is_verified from metadata that gets stored in user cache from fetchCID#1750
sliptype merged 3 commits into
mainfrom
sk-c-859-dont-read-verified-from-cn

Conversation

@sliptype

Copy link
Copy Markdown
Contributor

Description

Dragons

Is there anything the reviewer should be on the lookout for? Are there any dangerous changes?

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.

How will this change be monitored?

For features that are critical or could fail silently please describe the monitoring/alerting being added.

Feature Flags

Are all new features properly feature flagged? Describe added feature flags.

@audius-infra

Copy link
Copy Markdown
Collaborator

{
id: user.user_id,
metadata: { ...metadata, collectiblesOrderUnset: true }
metadata: {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also on line 76

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, fixed

@raymondjacobson raymondjacobson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unnecessary import, but lgtm now!

@sliptype sliptype merged commit 6c204c6 into main Aug 18, 2022
@sliptype sliptype deleted the sk-c-859-dont-read-verified-from-cn branch August 18, 2022 23:51
sliptype added a commit that referenced this pull request Aug 18, 2022
…he from fetchCID (#1750)

* Omit `is_verified` from metadata that gets stored in user cache after calling fetchCID

* Remove is_verified

* Remove unecessary import
sliptype added a commit that referenced this pull request Aug 18, 2022
…he from fetchCID (#1750)

* Omit `is_verified` from metadata that gets stored in user cache after calling fetchCID

* Remove is_verified

* Remove unecessary import
audius-infra pushed a commit that referenced this pull request Aug 20, 2022
[8caef33] [PAY-564] Enable LayoutAnimation on android for profile screen (#1754) Reed
[03c2e3d] [C-860] Fix failing mac ci build due to peer deps (#1749) Sebastian Klingler
[a88f8c0] Move Coinbase button into its own component (#1741) Marcus Pasell
[6c204c6] [C-859] Omit `is_verified` from metadata that gets stored in user cache from fetchCID (#1750) Sebastian Klingler
[03eba06] Add bounds to $AUDIO purchase (#1744) Marcus Pasell
[885202d] Bump iOS build (#1748) Michael Piazza
[d035b6d] v1.3.0 (#1740) Sebastian Klingler
[53128be] Update @audius/sdk to 0.0.37 (#1747) Sebastian Klingler
[992d243] Fix twitter share copy (#1746) Michael Piazza
[f783bf6] [PAY-540] Add analytics to buy audio flow (#1673) Marcus Pasell
[898fc0a] Get sign in/out working end to end (#1739) Raymond Jacobson
[94686ef] Bump ios version (#1742) Sebastian Klingler
@AudiusProject AudiusProject deleted a comment from linear Bot Sep 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants