This repository was archived by the owner on Oct 4, 2023. It is now read-only.
Add bounds to $AUDIO purchase#1744
Merged
Merged
Conversation
Collaborator
|
Preview this change https://demo.audius.co/mjp-fail-quote |
dharit-tan
approved these changes
Aug 18, 2022
Collaborator
|
Preview this change https://demo.audius.co/mjp-fail-quote |
audius-infra
pushed a commit
that referenced
this pull request
Aug 20, 2022
[8caef33] [PAY-564] Enable LayoutAnimation on android for profile screen (#1754) Reed [03c2e3d] [C-860] Fix failing mac ci build due to peer deps (#1749) Sebastian Klingler [a88f8c0] Move Coinbase button into its own component (#1741) Marcus Pasell [6c204c6] [C-859] Omit `is_verified` from metadata that gets stored in user cache from fetchCID (#1750) Sebastian Klingler [03eba06] Add bounds to $AUDIO purchase (#1744) Marcus Pasell [885202d] Bump iOS build (#1748) Michael Piazza [d035b6d] v1.3.0 (#1740) Sebastian Klingler [53128be] Update @audius/sdk to 0.0.37 (#1747) Sebastian Klingler [992d243] Fix twitter share copy (#1746) Michael Piazza [f783bf6] [PAY-540] Add analytics to buy audio flow (#1673) Marcus Pasell [898fc0a] Get sign in/out working end to end (#1739) Raymond Jacobson [94686ef] Bump ios version (#1742) Sebastian Klingler
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fails the quote if the purchase amount is outside the remote configured bounds.
Note: propagates the min/max to the store so they be used in the error message without having to query remote config twice, using some nice discriminated unions.
Dragons
Is there anything the reviewer should be on the lookout for? Are there any dangerous changes?
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.
How will this change be monitored?
For features that are critical or could fail silently please describe the monitoring/alerting being added.
Feature Flags
Are all new features properly feature flagged? Describe added feature flags.