Skip to content
This repository was archived by the owner on Oct 4, 2023. It is now read-only.

[PAY-540] Add analytics to buy audio flow#1673

Merged
rickyrombo merged 6 commits into
mainfrom
mjp-amp-onramp-sagas
Aug 18, 2022
Merged

[PAY-540] Add analytics to buy audio flow#1673
rickyrombo merged 6 commits into
mainfrom
mjp-amp-onramp-sagas

Conversation

@rickyrombo

@rickyrombo rickyrombo commented Aug 4, 2022

Copy link
Copy Markdown
Contributor

Description

Adds analytics in amplitude to the Buy Audio flow.

  • Tracks the opening of the on ramp flow so we can see how many users make it through the 3rd-party onramp funnel, and how long it takes them
  • Tracks the success/failure, with the surplus (or deficit) $AUDIO amount in the success case to measure how good our exchange accuracy is.

Dragons

Is there anything the reviewer should be on the lookout for? Are there any dangerous changes?

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.

Tested on local against prod, verified in amplitude

How will this change be monitored?

For features that are critical or could fail silently please describe the monitoring/alerting being added.

This is monitoring!

Feature Flags

Are all new features properly feature flagged? Describe added feature flags.

@rickyrombo rickyrombo mentioned this pull request Aug 4, 2022
2 tasks
@audius-infra

Copy link
Copy Markdown
Collaborator

Preview this change https://demo.audius.co/mjp-amp-onramp-sagas

1 similar comment
@audius-infra

Copy link
Copy Markdown
Collaborator

Preview this change https://demo.audius.co/mjp-amp-onramp-sagas

Base automatically changed from mjp-cb-onramp-sagas-v2 to main August 12, 2022 22:33
@rickyrombo rickyrombo changed the title Add analytics to buy audio flow [PAY-540] Add analytics to buy audio flow Aug 16, 2022
@rickyrombo rickyrombo marked this pull request as ready for review August 16, 2022 23:11
@rickyrombo rickyrombo requested a review from piazzatron August 16, 2022 23:11
@audius-infra

Copy link
Copy Markdown
Collaborator

Preview this change https://demo.audius.co/mjp-amp-onramp-sagas

@piazzatron piazzatron left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, apologies for delay!

Comment thread packages/web/src/store/application/ui/buy-audio/sagas.ts
@audius-infra

Copy link
Copy Markdown
Collaborator

Preview this change https://demo.audius.co/mjp-amp-onramp-sagas

@rickyrombo rickyrombo merged commit f783bf6 into main Aug 18, 2022
@rickyrombo rickyrombo deleted the mjp-amp-onramp-sagas branch August 18, 2022 19:00
audius-infra pushed a commit that referenced this pull request Aug 20, 2022
[8caef33] [PAY-564] Enable LayoutAnimation on android for profile screen (#1754) Reed
[03c2e3d] [C-860] Fix failing mac ci build due to peer deps (#1749) Sebastian Klingler
[a88f8c0] Move Coinbase button into its own component (#1741) Marcus Pasell
[6c204c6] [C-859] Omit `is_verified` from metadata that gets stored in user cache from fetchCID (#1750) Sebastian Klingler
[03eba06] Add bounds to $AUDIO purchase (#1744) Marcus Pasell
[885202d] Bump iOS build (#1748) Michael Piazza
[d035b6d] v1.3.0 (#1740) Sebastian Klingler
[53128be] Update @audius/sdk to 0.0.37 (#1747) Sebastian Klingler
[992d243] Fix twitter share copy (#1746) Michael Piazza
[f783bf6] [PAY-540] Add analytics to buy audio flow (#1673) Marcus Pasell
[898fc0a] Get sign in/out working end to end (#1739) Raymond Jacobson
[94686ef] Bump ios version (#1742) Sebastian Klingler
@AudiusProject AudiusProject deleted a comment from linear Bot Sep 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants