Skip to content
This repository was archived by the owner on Oct 4, 2023. It is now read-only.

Fetch live playlists for landing page#1535

Merged
nicoback2 merged 2 commits into
nkang--mobile-menu-websitefrom
nkang--fetch-live-playlists
Jun 29, 2022
Merged

Fetch live playlists for landing page#1535
nicoback2 merged 2 commits into
nkang--mobile-menu-websitefrom
nkang--fetch-live-playlists

Conversation

@nicoback2

Copy link
Copy Markdown
Contributor

Description

Use live trending playlists for the featured content section

Dragons

Is there anything the reviewer should be on the lookout for? Are there any dangerous changes?

How Has This Been Tested?

In browser
Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.

How will this change be monitored?

For features that are critical or could fail silently please describe the monitoring/alerting being added.

Feature Flags

Are all new features properly feature flagged? Describe added feature flags.

@nicoback2 nicoback2 requested a review from sliptype June 29, 2022 17:02
@audius-infra

Copy link
Copy Markdown
Collaborator

Preview this change https://demo.audius.co/nkang--fetch-live-playlists

@nicoback2 nicoback2 force-pushed the nkang--fetch-live-playlists branch from 12571a7 to a8944e7 Compare June 29, 2022 17:44
@audius-infra

Copy link
Copy Markdown
Collaborator

Preview this change https://demo.audius.co/nkang--fetch-live-playlists

@nicoback2 nicoback2 force-pushed the nkang--fetch-live-playlists branch from 7f11ed9 to 8a063a7 Compare June 29, 2022 18:33
@audius-infra

Copy link
Copy Markdown
Collaborator

Preview this change https://demo.audius.co/nkang--fetch-live-playlists

@sliptype sliptype left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@nicoback2 nicoback2 merged commit 56519d5 into nkang--mobile-menu-website Jun 29, 2022
@nicoback2 nicoback2 deleted the nkang--fetch-live-playlists branch June 29, 2022 19:41
nicoback2 added a commit that referenced this pull request Jul 1, 2022
* mobile menu changes

* wuikfix

* right link fix

* nav banner fix

* downloads page

* background size fix

* download link fix

* small fixes

* Fix links from public site with redirect (#1520)

* fix margins on ipad for downloadsp age

* fix parallax kinda

* fix image circles

* qa re: padding

* quick featured content fix

* progressive imgs, clean imgs

* smaller images

* change bg color

* Fetch live playlists for landing page (#1535)

* fetch live playlists for landing page

* use 1000x1000

Co-authored-by: Nikki Kang <kangaroo233@gmail.com>

* dowload page fixes

* button shadow fixes

* change source of playlist

* featured content qa

Co-authored-by: Nikki Kang <kangaroo233@gmail.com>
Co-authored-by: Raymond Jacobson <ray@audius.co>
nicoback2 added a commit that referenced this pull request Jul 1, 2022
* desktop changes

* mobile and footer

* fix hero img

* fix ipad text

* fix ts errors

* kbs fix

* hero fixes

* upgrade stems

* [Landing page redesign] Mobile nav menu + Downloads Page (#1506)

* mobile menu changes

* wuikfix

* right link fix

* nav banner fix

* downloads page

* background size fix

* download link fix

* small fixes

* Fix links from public site with redirect (#1520)

* fix margins on ipad for downloadsp age

* fix parallax kinda

* fix image circles

* qa re: padding

* quick featured content fix

* progressive imgs, clean imgs

* smaller images

* change bg color

* Fetch live playlists for landing page (#1535)

* fetch live playlists for landing page

* use 1000x1000

Co-authored-by: Nikki Kang <kangaroo233@gmail.com>

* dowload page fixes

* button shadow fixes

* change source of playlist

* featured content qa

Co-authored-by: Nikki Kang <kangaroo233@gmail.com>
Co-authored-by: Raymond Jacobson <ray@audius.co>

Co-authored-by: Nikki Kang <kangaroo233@gmail.com>
Co-authored-by: Raymond Jacobson <ray@audius.co>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants