Skip to content
This repository was archived by the owner on Oct 4, 2023. It is now read-only.

[Landing page redesign] Mobile nav menu + Downloads Page#1506

Merged
nicoback2 merged 22 commits into
nkang--websitefrom
nkang--mobile-menu-website
Jul 1, 2022
Merged

[Landing page redesign] Mobile nav menu + Downloads Page#1506
nicoback2 merged 22 commits into
nkang--websitefrom
nkang--mobile-menu-website

Conversation

@nicoback2

@nicoback2 nicoback2 commented Jun 23, 2022

Copy link
Copy Markdown
Contributor

Description

Screen Shot 2022-06-23 at 11 28 44 AM

screencapture-localhost-3001-download-2022-06-23-11_26_43

Dragons

Is there anything the reviewer should be on the lookout for? Are there any dangerous changes?

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.

How will this change be monitored?

For features that are critical or could fail silently please describe the monitoring/alerting being added.

@audius-infra

Copy link
Copy Markdown
Collaborator

Preview this change https://demo.audius.co/nkang--mobile-menu-website

justify-content: center;
color: #480b79;
font-family: Gilroy !important;
color: #7e1bcc;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be secondary color var?

Comment on lines +79 to +82
background-color: #ffffff;
box-shadow: 0px 0px 1px -2px rgba(133, 129, 153, 0.1),
0px 1px 0px -2px #e3e3e3, 1px 2px 5px rgba(133, 129, 153, 0.25);
color: #7e1bcc;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should use color vars here too

Comment on lines +40 to +43
console.log(route)
if (route.startsWith('http') || LANDING_PAGE_ROUTES.has(route)) {
pushWindowRoute(route)
console.log('here')

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logs

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops

<CookieBanner
isMobile={props.isMobile}
isPlaying={false}
// @ts-ignore

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what was happening here?

@Kyle-Shanks Kyle-Shanks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 👍

@nicoback2 nicoback2 force-pushed the nkang--mobile-menu-website branch from 4a6bbb2 to 8a90d36 Compare June 23, 2022 18:32
@audius-infra

Copy link
Copy Markdown
Collaborator

Preview this change https://demo.audius.co/nkang--mobile-menu-website

@audius-infra

Copy link
Copy Markdown
Collaborator

Preview this change https://demo.audius.co/nkang--mobile-menu-website

@audius-infra

Copy link
Copy Markdown
Collaborator

Preview this change https://demo.audius.co/nkang--mobile-menu-website

@audius-infra

Copy link
Copy Markdown
Collaborator

Preview this change https://demo.audius.co/nkang--mobile-menu-website

@audius-infra

Copy link
Copy Markdown
Collaborator

Preview this change https://demo.audius.co/nkang--mobile-menu-website

@audius-infra

Copy link
Copy Markdown
Collaborator

Preview this change https://demo.audius.co/nkang--mobile-menu-website

@audius-infra

Copy link
Copy Markdown
Collaborator

Preview this change https://demo.audius.co/nkang--mobile-menu-website

@audius-infra

Copy link
Copy Markdown
Collaborator

Preview this change https://demo.audius.co/nkang--mobile-menu-website

* fetch live playlists for landing page

* use 1000x1000

Co-authored-by: Nikki Kang <kangaroo233@gmail.com>
@audius-infra

Copy link
Copy Markdown
Collaborator

Preview this change https://demo.audius.co/nkang--mobile-menu-website

@audius-infra

Copy link
Copy Markdown
Collaborator

Preview this change https://demo.audius.co/nkang--mobile-menu-website

@audius-infra

Copy link
Copy Markdown
Collaborator

Preview this change https://demo.audius.co/nkang--mobile-menu-website

@nicoback2 nicoback2 merged commit f30730b into nkang--website Jul 1, 2022
@nicoback2 nicoback2 deleted the nkang--mobile-menu-website branch July 1, 2022 15:02
nicoback2 added a commit that referenced this pull request Jul 1, 2022
* desktop changes

* mobile and footer

* fix hero img

* fix ipad text

* fix ts errors

* kbs fix

* hero fixes

* upgrade stems

* [Landing page redesign] Mobile nav menu + Downloads Page (#1506)

* mobile menu changes

* wuikfix

* right link fix

* nav banner fix

* downloads page

* background size fix

* download link fix

* small fixes

* Fix links from public site with redirect (#1520)

* fix margins on ipad for downloadsp age

* fix parallax kinda

* fix image circles

* qa re: padding

* quick featured content fix

* progressive imgs, clean imgs

* smaller images

* change bg color

* Fetch live playlists for landing page (#1535)

* fetch live playlists for landing page

* use 1000x1000

Co-authored-by: Nikki Kang <kangaroo233@gmail.com>

* dowload page fixes

* button shadow fixes

* change source of playlist

* featured content qa

Co-authored-by: Nikki Kang <kangaroo233@gmail.com>
Co-authored-by: Raymond Jacobson <ray@audius.co>

Co-authored-by: Nikki Kang <kangaroo233@gmail.com>
Co-authored-by: Raymond Jacobson <ray@audius.co>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants