This repository was archived by the owner on Oct 4, 2023. It is now read-only.
Fix redirect links - #1520
Merged
Merged
Conversation
Collaborator
|
Preview this change https://demo.audius.co/rj-fix-redirect-links |
Contributor
|
Thank you!!! 🙏 |
nicoback2
approved these changes
Jun 27, 2022
nicoback2
added a commit
that referenced
this pull request
Jul 1, 2022
* mobile menu changes * wuikfix * right link fix * nav banner fix * downloads page * background size fix * download link fix * small fixes * Fix links from public site with redirect (#1520) * fix margins on ipad for downloadsp age * fix parallax kinda * fix image circles * qa re: padding * quick featured content fix * progressive imgs, clean imgs * smaller images * change bg color * Fetch live playlists for landing page (#1535) * fetch live playlists for landing page * use 1000x1000 Co-authored-by: Nikki Kang <kangaroo233@gmail.com> * dowload page fixes * button shadow fixes * change source of playlist * featured content qa Co-authored-by: Nikki Kang <kangaroo233@gmail.com> Co-authored-by: Raymond Jacobson <ray@audius.co>
nicoback2
added a commit
that referenced
this pull request
Jul 1, 2022
* desktop changes * mobile and footer * fix hero img * fix ipad text * fix ts errors * kbs fix * hero fixes * upgrade stems * [Landing page redesign] Mobile nav menu + Downloads Page (#1506) * mobile menu changes * wuikfix * right link fix * nav banner fix * downloads page * background size fix * download link fix * small fixes * Fix links from public site with redirect (#1520) * fix margins on ipad for downloadsp age * fix parallax kinda * fix image circles * qa re: padding * quick featured content fix * progressive imgs, clean imgs * smaller images * change bg color * Fetch live playlists for landing page (#1535) * fetch live playlists for landing page * use 1000x1000 Co-authored-by: Nikki Kang <kangaroo233@gmail.com> * dowload page fixes * button shadow fixes * change source of playlist * featured content qa Co-authored-by: Nikki Kang <kangaroo233@gmail.com> Co-authored-by: Raymond Jacobson <ray@audius.co> Co-authored-by: Nikki Kang <kangaroo233@gmail.com> Co-authored-by: Raymond Jacobson <ray@audius.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
See comment
Dragons
Is there anything the reviewer should be on the lookout for? Are there any dangerous changes?
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.
Locally vs. prod
How will this change be monitored?
For features that are critical or could fail silently please describe the monitoring/alerting being added.
Feature Flags
Are all new features properly feature flagged? Describe added feature flags.