Skip to content

set AWS_S3_FORCE_PATH_STYLE accordingly #670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CyberDem0n merged 1 commit into from
Dec 6, 2021
+12 −3
Merged

set AWS_S3_FORCE_PATH_STYLE accordingly #670

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions postgres-appliance/scripts/configure_spilo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -783,11 +783,20 @@ def write_wale_environment(placeholders, prefix, overwrite):

# for S3-compatible storage we want to specify WALE_S3_ENDPOINT and AWS_ENDPOINT, but not AWS_REGION
if aws_endpoint or wale_endpoint:
if not aws_endpoint:
aws_endpoint = wale_endpoint.replace('+path://', '://')
elif not wale_endpoint:
convention = 'path'
if not wale_endpoint:
wale_endpoint = aws_endpoint.replace('://', '+path://')
else:
match = re.match(r'^(\w+)\+(\w+)(://.+)$', wale_endpoint)
if match:
convention = match.group(2)
else:
logging.warning('Invalid WALE_S3_ENDPOINT, the format is protocol+convention://hostname:port, '
'but got %s', wale_endpoint)
if not aws_endpoint:
aws_endpoint = match.expand(r'\1\3') if match else wale_endpoint
wale.update(WALE_S3_ENDPOINT=wale_endpoint, AWS_ENDPOINT=aws_endpoint, WALG_DISABLE_S3_SSE='true')
wale['AWS_S3_FORCE_PATH_STYLE'] = 'true' if convention == 'path' else 'false'
if aws_region and wale.get('USE_WALG_BACKUP') == 'true':
wale['AWS_REGION'] = aws_region
elif not aws_region:
Expand Down