set AWS_S3_FORCE_PATH_STYLE accordingly #670
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1a11890 to
65e2a73
Compare
WAL-G will not work if we use our own endpoint that only supports path convention but AWS_S3_FORCE_PATH_STYLE is not set. This patch ensures that WAL-G and WAL-E will use the same convention. Also add support to WALE_S3_ENDPOINT with convention other than path. Signed-off-by: 胡玮文 <[email protected]>
Member
|
👍 |
1 similar comment
Contributor
|
👍 |
christoph-heiss
pushed a commit
to cybertec-postgresql/spilo
that referenced
this pull request
Mar 29, 2022
WAL-G will not work if we use our own endpoint that only supports path convention but AWS_S3_FORCE_PATH_STYLE is not set. This patch ensures that WAL-G and WAL-E will use the same convention. Also add support to WALE_S3_ENDPOINT with convention other than path.
zer0def
pushed a commit
to zer0def/spilo
that referenced
this pull request
May 28, 2022
WAL-G will not work if we use our own endpoint that only supports path convention but AWS_S3_FORCE_PATH_STYLE is not set. This patch ensures that WAL-G and WAL-E will use the same convention. Also add support to WALE_S3_ENDPOINT with convention other than path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WAL-G will not work if we use our own endpoint that only supports path convention but AWS_S3_FORCE_PATH_STYLE is not set. This patch ensures that WAL-G and WAL-E will use the same convention.
Also add support to WALE_S3_ENDPOINT with convention other than path.
Signed-off-by: 胡玮文 [email protected]