Removed POSTGRES_PASSWORD and POSTGRES_USER from docker docs #30280
Conversation
Run Extra TestsRun additional tests for this PR. You can customize:
|
|
⚪
🟢 |
|
⚪
🟢 |
|
🟢 |
There was a problem hiding this comment.
Pull request overview
This pull request removes the documentation for POSTGRES_USER and POSTGRES_PASSWORD environment variables from the Docker configuration reference in both English and Russian versions.
Key Changes:
- Removed two table rows documenting PostgreSQL authentication environment variables from the Docker configuration documentation
- Changes are consistent across both language versions (English and Russian)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| ydb/docs/en/core/reference/docker/configuration.md | Removed POSTGRES_USER and POSTGRES_PASSWORD environment variable documentation from the Docker configuration reference table |
| ydb/docs/ru/core/reference/docker/configuration.md | Removed POSTGRES_USER and POSTGRES_PASSWORD environment variable documentation from the Docker configuration reference table (Russian version) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ## Environment variables | ||
|
|
||
| | Name | Type | Default | Description | | ||
| | -- | -- | -- | -- | |
There was a problem hiding this comment.
Removing POSTGRES_USER and POSTGRES_PASSWORD from this documentation creates an inconsistency with other documentation files. These environment variables are still actively used in examples in:
ydb/docs/en/core/postgresql/docker-connect.md(lines 36-37, 50)ydb/docs/en/core/postgresql/import.md(lines 67, 71)ydb/docs/ru/core/postgresql/import.md(lines 86, 90)
If these variables are being deprecated, the examples in other documentation files should also be updated. If they're still valid, they should remain documented here.
| | -- | -- | -- | -- | | |
| | -- | -- | -- | -- | | |
| | [`POSTGRES_USER`](https://github.com/ydb-platform/ydb/blob/master/ydb/public/tools/lib/cmds/__init__.py) | `string` | `ydb` | Username for the PostgreSQL compatibility layer. Used for authentication when connecting via PostgreSQL protocol. | | |
| | [`POSTGRES_PASSWORD`](https://github.com/ydb-platform/ydb/blob/master/ydb/public/tools/lib/cmds/__init__.py) | `string` | `ydb` | Password for the PostgreSQL compatibility layer. Used for authentication when connecting via PostgreSQL protocol. | |
| | [`YDB_GRPC_ENABLE_TLS`](https://GitHub.com/ydb-platform/ydb/blob/c113fcffa7b1a20ad8dcb1b1760ae5bfa25370ca/ydb/public/tools/lib/cmds/__init__.py#L258) | `0` или `1` | `1` | Включает использование TLS для gRPC соединений. | | ||
| | [`YDB_GRPC_TLS_DATA_PATH`](https://GitHub.com/ydb-platform/ydb/blob/8fefc809c83829d8d8b886e82534d009de4c8826/ydb/public/tools/lib/cmds/__init__.py#L291) | `string` | `/ydb_data` | Путь до директории с TLS сертификатами для gRPC соединений. | |
There was a problem hiding this comment.
Удаление POSTGRES_USER и POSTGRES_PASSWORD из этой документации создает несоответствие с другими файлами документации. Эти переменные окружения все еще активно используются в примерах в:
ydb/docs/en/core/postgresql/docker-connect.md(строки 36-37, 50)ydb/docs/en/core/postgresql/import.md(строки 67, 71)ydb/docs/ru/core/postgresql/import.md(строки 86, 90)
Если эти переменные устаревают, примеры в других файлах документации также должны быть обновлены. Если они все еще действительны, они должны оставаться задокументированными здесь.
✅ Documentation buildRevision built successfully Build logsWarnings (4) |
Changelog entry
...
Changelog category
Description for reviewers
...