Update: Dimension Service all should get ALL#1349
Merged
kevinhinterlong merged 5 commits intomasterfrom Apr 13, 2021
Merged
Conversation
jkusa
reviewed
Apr 1, 2021
4744645 to
f225b2e
Compare
- The dimension service will page through dimensions until all values have been fetched
Co-authored-by: Jon Kilroy <jkilroy@gmail.com>
9f55edf to
277f48b
Compare
jkusa
reviewed
Apr 13, 2021
| * @param request - request for response payload | ||
| */ | ||
| normalize(payload: unknown, request: RequestV1 | RequestV2): NaviFactResponse | undefined; | ||
| normalize(payload: unknown, request: RequestV2, options?: RequestOptions): NaviFactResponse | undefined; |
jkusa
approved these changes
Apr 13, 2021
Contributor
jkusa
left a comment
There was a problem hiding this comment.
Just the one question, otherwise 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes a bug that was introduced by #1333 where the dimension select would fetch
allvalues using the dimension service, but it wouldn't page through results (e.g. an elide dimension with 700 results but the pageSize is 500 you would only get the first 500 values).Proposed Changes
searchThresholdsconfig option tocardinalities: { small, medium }License
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.