Update: Use Ember concurrency for data interfaces/adapters#1333
Merged
kevinhinterlong merged 5 commits intomasterfrom Mar 29, 2021
Merged
Update: Use Ember concurrency for data interfaces/adapters#1333kevinhinterlong merged 5 commits intomasterfrom
kevinhinterlong merged 5 commits intomasterfrom
Conversation
5124f39 to
e3efa40
Compare
jkusa
reviewed
Mar 25, 2021
Contributor
jkusa
left a comment
There was a problem hiding this comment.
Do we have any tests that exercise the cancel functionality?
jkusa
approved these changes
Mar 29, 2021
added 5 commits
March 29, 2021 13:28
Allow for typeahead/facts queries to be cancelled
4c18f87 to
1b3933b
Compare
This was referenced Mar 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update facts/dimension adapters and services to use ember-concurrency tasks. Cancels elide queries we no longer use
Proposed Changes
License
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.