Conversation
tonycosentini
approved these changes
Dec 27, 2016
ZacSweers
commented
Dec 28, 2016
Collaborator
Author
There was a problem hiding this comment.
@tonycosentini this is the one that fails, but I'm not totally sure what's going on with it or what this is testing. Want to take a look?
Collaborator
Author
|
Going to revisit this after #29 is in |
4509b7d to
1c38be7
Compare
f450285 to
4ed1721
Compare
In happy cases, AutoDisposing observers should effectively have identical behavior, so borrowing this test. Still one kink to work out with handling bad onSubscribes, but putting this up to start and get eyes. Once `LambdaObserverTest` is good to go, I'll add LambdaSubscriberTest
4ed1721 to
1dc078f
Compare
It's a defensive test and one we can revisit later
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In happy cases, AutoDisposing observers should effectively have identical behavior, so borrowing this test. Still one kink to work out with handling bad onSubscribes, but putting this up to start and get eyes. Once
LambdaObserverTestis good to go, I'll addLambdaSubscriberTest.Note this depends on #1