Conversation
Prior, we weren't guaranteed to send an `onSubscribe()` callback to the wrapped observer if there was a lifecycle issue (pre-post lifecycle). This ensures that by doing the check in `dispose()`/`cancel()` and triggering it to be safe, while still preventing a full completion upstream (especially problematic for scalar flowables, which could otherwise completely complete in onSubscribe())
0332cd9 to
0b8fc38
Compare
tonycosentini
approved these changes
Dec 23, 2016
Contributor
tonycosentini
left a comment
There was a problem hiding this comment.
Looks good, although I'm not particularly qualified to understand the subtle details here :)
It would be cool to have a way to generate these at some point - if there's one more type it'll be kind of tedious.
ZacSweers
added a commit
that referenced
this pull request
Feb 16, 2017
Prior, we weren't guaranteed to send an `onSubscribe()` callback to the wrapped observer if there was a lifecycle issue (pre-post lifecycle). This ensures that by doing the check in `dispose()`/`cancel()` and triggering it to be safe, while still preventing a full completion upstream (especially problematic for scalar flowables, which could otherwise completely complete in onSubscribe())
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior, we weren't guaranteed to send an
onSubscribe()callback to the wrapped observer if there was a lifecycle issue (pre-post lifecycle). This ensures that by doing the check indispose()/cancel()and triggering it to be safe, while still preventing a full completion upstream (especially problematic for scalar flowables, which could otherwise completely complete in onSubscribe())