chore: Use title as name for non-ascii titles - #50
Merged
Conversation
3w36zj6
self-requested a review
August 25, 2024 14:10
3w36zj6
approved these changes
Aug 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #46
日本語の文字など英数字（ASCII）が含まれているMarkdown見出しに対し、
heckパッケージの変換を通したidではなく（通してしまうと英字以外が消されてしまうため）、そのままtitleを使うようにしました。title以外のものを目次にする場合は不便でしょうが、今のところ見出しをそのまま右に使っても構わないと判断したため、そのまま使うようにしました。また、titleが長いことが多いので、Reactの日本語ドキュメントのように文字サイズを小さくするほうが将来的に良さそうかもしれません。