Merged
Conversation
… for search param
fix: Update searchInvoices to use array for external ids + use lower camel case for search param
…he Invoice.SearchBy Enum, we take its key into account
LukasBil
reviewed
Aug 22, 2023
Comment on lines
148
to
153
| } | ||
| body = "{\""+searchBy.name()+"\":" | ||
| body = "{\""+searchBy.getKey()+"\":" | ||
| +new ObjectMapper() | ||
| .setSerializationInclusion(Include.NON_EMPTY) | ||
| .writeValueAsString(paramsList) | ||
| +"}"; |
There was a problem hiding this comment.
Instead of building it by hand, maybe you would like to do it somehow like this:
ObjectMapper objectMapper = new ObjectMapper().setSerializationInclusion(JsonInclude.Include.NON_EMPTY);
body = objectMapper.writeValueAsString(Map.of(searchBy.getKey(), paramsList));
LukasBil
approved these changes
Aug 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Checklist
If you have questions, create a GitHub Issue in this repository.