fix: Update searchInvoices to use array for external ids + use lower camel case for search param#30
Merged
Aman-Aalam merged 1 commit intotrolley:devfrom Aug 21, 2023
Conversation
… for search param
Contributor
Author
|
@Aman-Aalam could you please review (Github isn't letting me add reviewers) - thanks! Also cc @tobyheighway @sa-canva |
mortondaniel
commented
Aug 18, 2023
Aman-Aalam
approved these changes
Aug 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
I noticed that the searchInvoices API actually expects the search parameter (e.g.
externalId) in lowerCamelCase.However the SDK currently sends it in UPPER_SNAKE_CASE.
Additionally, if using
externalIdfiltering, it should be an array of values, rather than a single value (according to the API + from my testing)Checklist