Skip to content

fix: Update searchInvoices to use array for external ids + use lower camel case for search param#30

Merged
Aman-Aalam merged 1 commit intotrolley:devfrom
mortondaniel:fix-find-invoice
Aug 21, 2023
Merged

fix: Update searchInvoices to use array for external ids + use lower camel case for search param#30
Aman-Aalam merged 1 commit intotrolley:devfrom
mortondaniel:fix-find-invoice

Conversation

@mortondaniel
Copy link
Contributor

@mortondaniel mortondaniel commented Aug 18, 2023

Fixes

I noticed that the searchInvoices API actually expects the search parameter (e.g. externalId) in lowerCamelCase.
However the SDK currently sends it in UPPER_SNAKE_CASE.

Additionally, if using externalId filtering, it should be an array of values, rather than a single value (according to the API + from my testing)

Screenshot 2023-08-18 at 1 51 35 pm

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

@mortondaniel
Copy link
Contributor Author

mortondaniel commented Aug 18, 2023

@Aman-Aalam could you please review (Github isn't letting me add reviewers) - thanks!

Also cc @tobyheighway @sa-canva

@Aman-Aalam Aman-Aalam self-requested a review August 21, 2023 21:35
@Aman-Aalam Aman-Aalam changed the base branch from master to dev August 21, 2023 21:36
@Aman-Aalam Aman-Aalam merged commit 7960db0 into trolley:dev Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants