Skip to content

fix: Update searchInvoices to use array for external ids + use lower camel case for search param #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Aman-Aalam merged 1 commit into from
Aug 21, 2023
Merged

fix: Update searchInvoices to use array for external ids + use lower camel case for search param #30

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/main/java/com/trolley/trolley/InvoiceGateway.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,23 +141,23 @@ public List<Invoice> search(final SearchBy searchBy,
case INVOICE_ID:
case RECIPIENT_ID:
case INVOICE_NUMBER:
case EXTERNAL_ID:
case TAGS:
if(null == paramsList){
throw new InvalidFieldException("variable paramsList can not be null for the provided searchBy parameter. Refer to method's Javadoc for more details.");
}
body = "{\""+searchBy.name()+"\":"
body = "{\""+searchBy.getKey()+"\":"
+new ObjectMapper()
.setSerializationInclusion(Include.NON_EMPTY)
.writeValueAsString(paramsList)
+"}";
break;

case INVOICE_DATE:
case EXTERNAL_ID:
if(null == param){
throw new InvalidFieldException("variable param can not be null for the provided searchBy parameter. Refer to method's Javadoc for more details.");
}
body = "{\""+searchBy.name()+"\":\""+param+"\"}";
body = "{\""+searchBy.getKey()+"\":\""+param+"\"}";
break;
}
final String endPoint = "/v1/invoices/search/";
Expand Down