fix: git-standup find error (#1106) #1110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyperupcall
reviewed
Nov 11, 2023
| ## Set delimiter to newline for the loop | ||
| IFS=$'\n' | ||
| ## Recursively search for git repositories | ||
| PROJECT_DIRS=$(find "$INCLUDE_LINKS" . -maxdepth "$MAXDEPTH" -mindepth 0 -name .git) |
Collaborator
There was a problem hiding this comment.
Thank you for the catch! A simpler fix would be to remove the quotes from $INCLUDE_LINKS. Either way LGTM
Contributor
Author
There was a problem hiding this comment.
I implemented this way because of the shellcheck output:
➜ shellcheck git-extras/bin/git-standup
In git-extras/bin/git-standup line 244:
PROJECT_DIRS=$(find . -maxdepth $MAXDEPTH -mindepth 0 -name .git)
^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
PROJECT_DIRS=$(find . -maxdepth "$MAXDEPTH" -mindepth 0 -name .git)
For more information:
https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
Collaborator
There was a problem hiding this comment.
I see - yeah that would be a false positive. Unfortunately some ShellCheck rules seem to have a lot of false positives.
Contributor
Author
There was a problem hiding this comment.
I can change it to your suggestion. It's your decision.
But until now shellcheck like the file. ;)
Collaborator
There was a problem hiding this comment.
You can use something like #shellcheck disable=SC2086 to disable the spurious warning
dce1ffb to
7e67dd3
Compare
hyperupcall
approved these changes
Nov 12, 2023
| ## Set delimiter to newline for the loop | ||
| IFS=$'\n' | ||
| ## Recursively search for git repositories | ||
| PROJECT_DIRS=$(find "$INCLUDE_LINKS" . -maxdepth "$MAXDEPTH" -mindepth 0 -name .git) |
spacewander
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.