Skip to content

git standup recursive search fails if -L missing #1106

@rm--

Description

@rm--

[macOS 14.1.1, zsh, git-extras v7.1.0]

If I run git standup in a parent directory of some git-repositories.
git standup fails with:

find: : No such file or directory

If I run bash -x /usr/local/bin/git-standup, I see:

++ find '' . -maxdepth 2 -mindepth 0 -name .git
find: : No such file or directory

That's because of the quoted empty value of: $INCLUDE_LINKS in
PROJECT_DIRS=$(find "$INCLUDE_LINKS" . -maxdepth "$MAXDEPTH" -mindepth 0 -name .git)
(https://github.com/tj/git-extras/blob/main/bin/git-standup#L243)

Since $INCLUDE_LINKS is only set if -L option is used, IMO there should be a handling of the empty value or the variable should have some valid value which find can handle.
(https://github.com/tj/git-extras/blob/main/bin/git-standup#L124)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions