zephyr: trace: remove useless #ifdef __ZEPHYR__ macro #4236
Conversation
Commit 8357dcf ("zephyr: trace: use zephyr utilities when enabled") added Zephyr's sys/printk.h in order to fix: warning: implicit declaration of function 'printk'. Remove #ifdef __ZEPHYR__ macro since this is not needed, because the whole file is for Zephyr only. Fixes: 8357dcf ("zephyr: trace: use zephyr utilities when enabled") Signed-off-by: Iuliana Prodan <[email protected]>
paulstelian97
left a comment
There was a problem hiding this comment.
Are these files supposed to be independent from those outside the Zephyr tree? I don't like the potential for these two versions of essentially the same file having a chance to diverge from one another.
What is under zephy/ is for Zephyr build. There are no corresponding files in Zephyr repo (i.e. there is no trace.h in Zephyr other than the one from modules/audio/sof). |
marc-hb
left a comment
There was a problem hiding this comment.
Are these files supposed to be independent from those outside the Zephyr tree?
They're temporary hacks to build SOF with Zephyr.
I'm not sure what you mean by "independent".
Also, when you write "the Zephyr tree" do you mean zephyrproject-rtos/zephyr/ or thesofproject/sof/zephyr ?
I don't like the potential for these two versions of essentially the same file having a chance to diverge from one another.
There's already a dozen trace.h files in thesofproject/sof BTW, were you thinking about one in particular?
|
CI showing unrelated DUT boot failure. |
Commit 8357dcf ("zephyr: trace: use zephyr utilities when enabled")
added Zephyr's sys/printk.h in order to fix:
warning: implicit declaration of function 'printk'.
Remove #ifdef ZEPHYR macro since this is not needed, because
the whole file is for Zephyr only.
Fixes: 8357dcf ("zephyr: trace: use zephyr utilities when enabled")
Signed-off-by: Iuliana Prodan [email protected]