Math: Trignometry: Cordic sine() and cos()#4218
Merged
Conversation
c88cdc0 to
e76ff37
Compare
paulstelian97
approved these changes
May 20, 2021
lgirdwood
requested changes
May 20, 2021
Member
lgirdwood
left a comment
There was a problem hiding this comment.
Code is fine, but commit message should state this PR is just moving existing code to improve runtime performance due to less function calls.
Add static inline for math sin() and cos() functions.This PR is just moving existing code to improve runtime performance due to less function calls Signed-off-by: ShriramShastry <malladi.sastry@intel.com>
e76ff37 to
ae00e53
Compare
lgirdwood
approved these changes
May 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce static inline function for sin() and cos()
function
Signed-off-by: ShriramShastry malladi.sastry@intel.com