[RFC]Math: Trignometry: Added cordic cos function by ShriramShastry · Pull Request #4053 · thesofproject/sof

ShriramShastry · 2021-04-19T13:15:52Z

…ange is [-2pi to 2pi] and output range is [-1 to +1] Mean and maximum value for the difference between floating to fixed point output is 3.2136e-09 and 0.0000000596

Signed-off-by: ShriramShastry malladi.sastry@intel.com

cujomalainey

please address checkpatch comments, also im not sure if Johny has mentioned but we are seeing a performance regression with the new sign function that i think we need to figure out before we land this

test/cmocka/src/math/trig/sin_fixed.c

test/cmocka/src/math/trig/cos_fixed.c

ShriramShastry · 2021-04-20T02:27:04Z

please address checkpatch comments, also im not sure if Johny has mentioned but we are seeing a performance regression with the new sign function that i think we need to figure out before we land this

It seems exp_fixed function is consuming most of the computation time in 3 band DRC. CORDIC SINE when compared with old sine performs better #3990 (comment)

src/math/trig.c

paulstelian97 · 2021-04-20T08:51:13Z

Isn't it literally possible to do cos(x) = sin(pi/2 - x)?

ShriramShastry · 2021-04-20T09:07:19Z

Isn't it literally possible to do cos(x) = sin(pi/2 - x)?

Yes, this is done by the during coordinate check pi/2. Variable xn and b_yn share

Isn't it literally possible to do cos(x) = sin(pi/2 - x)?

Yes , this is done during co-ordinate check. th_rad_fxp = sign * b_yn; for sine and th_rad_fxp = sign * xn for cosine.

paulstelian97 · 2021-04-20T09:09:11Z

Isn't it literally possible to do cos(x) = sin(pi/2 - x)?

Yes, this is done by the during coordinate check pi/2. Variable xn and b_yn share

Isn't it literally possible to do cos(x) = sin(pi/2 - x)?

Yes , this is done during co-ordinate check. th_rad_fxp = sign * b_yn; for sine and th_rad_fxp = sign * xn for cosine.

Guess that's a lot of common code then, we can factor out the common part into a single function to avoid code duplication.

ShriramShastry · 2021-04-20T09:16:17Z

Isn't it literally possible to do cos(x) = sin(pi/2 - x)?

Yes, this is done by the during coordinate check pi/2. Variable xn and b_yn share

Isn't it literally possible to do cos(x) = sin(pi/2 - x)?

Yes , this is done during co-ordinate check. th_rad_fxp = sign * b_yn; for sine and th_rad_fxp = sign * xn for cosine.

Guess that's a lot of common code then, we can factor out the common part into a single function to avoid code duplication.

Yes. That's correct, will make common function with a separator for sine and cosine.

src/math/trig.c

src/audio/Kconfig

paulstelian97

I assume by now the mathematical kinks of the function itself are solved (and thus we now know it's correct); the code itself looks good.

src/audio/drc/drc_math_generic.c

src/include/sof/math/trig.h

src/audio/drc/drc_math_generic.c

test/cmocka/src/math/trig/cos_16B_fixed.c

test/cmocka/src/math/trig/cos_32B_fixed.c

src/include/sof/math/trig.h

Cordic sin cos input value range is [-2*pi to 2*pi] and output range is [-1 to +1] This is common function to calculate trignometric sine and cosine using separate lookup table size for speeds and accuracy calculation. For 32bit sine and cosine Error (max = 0.000000011175871), THD+N = -170.152933 For 16bit sine and cosine Error (max = 0.000061), THD+N = -91.518584 Signed-off-by: ShriramShastry <malladi.sastry@intel.com>

singalsu

Looks good, thanks Sriram!

singalsu

Re-approve, previous got cleared.

lgirdwood · 2021-05-19T09:57:47Z

src/audio/drc/drc_math_generic.c

 inline int32_t drc_sin_fixed(int32_t x)
 {
-	const int32_t PI_OVER_TWO = Q_CONVERT_FLOAT(1.57079632679489661923f, 30);
+	const int32_t PI_OVER_TWO = Q_CONVERT_FLOAT(1.57079632679489661923, 30);


These will only be inline if they are used in the same C file. @ShriramShastry can you do an incremental update that takes all these small inline maths function and moves them to the maths headers (and changes them to static inline).
This will save us a function call on all our small maths ops.

Thanks Liam, Seppo. I have a new PR #4218 to include your inputs.

lgirdwood · 2021-05-19T09:59:39Z

src/math/trig.c

+ */
+inline int32_t sin_fixed_32b(int32_t th_rad_fxp)
+{
+	int32_t sign;


e.g. here, as this will generate 2 function calls when used outside of trig.c i.e.

sin_fixed_32b()

cordic_sin_cos()

We want to eliminate call 1.

Same for all the other small maths functions.

ShriramShastry force-pushed the shastry_cordiccos_dev branch 5 times, most recently from 458b5f3 to 81a0484 Compare April 19, 2021 14:07

ShriramShastry changed the title ~~Math: Trignometry: Added cordic cos function Cordic cos input value r…~~ [RFC]Math: Trignometry: Added cordic cos function Apr 19, 2021

lgirdwood requested review from cujomalainey, johnylin76 and singalsu April 19, 2021 15:38

cujomalainey suggested changes Apr 19, 2021

View reviewed changes

test/cmocka/src/math/trig/sin_fixed.c Outdated Show resolved Hide resolved

test/cmocka/src/math/trig/cos_fixed.c Outdated Show resolved Hide resolved

singalsu requested changes Apr 20, 2021

View reviewed changes

src/math/trig.c Outdated Show resolved Hide resolved

src/math/trig.c Outdated Show resolved Hide resolved

src/math/trig.c Outdated Show resolved Hide resolved

ShriramShastry requested a review from slawblauciak April 20, 2021 09:30

ShriramShastry force-pushed the shastry_cordiccos_dev branch 11 times, most recently from 6042ff3 to d5d1363 Compare April 21, 2021 02:00

cujomalainey reviewed Apr 21, 2021

View reviewed changes

src/math/trig.c Outdated Show resolved Hide resolved

ShriramShastry force-pushed the shastry_cordiccos_dev branch from d5d1363 to 8e5ff14 Compare April 21, 2021 07:15

paulstelian97 reviewed May 12, 2021

View reviewed changes

src/audio/Kconfig Outdated Show resolved Hide resolved

ShriramShastry force-pushed the shastry_cordiccos_dev branch 5 times, most recently from 2a3b52b to 25395e0 Compare May 12, 2021 13:42

paulstelian97 approved these changes May 12, 2021

View reviewed changes

ShriramShastry force-pushed the shastry_cordiccos_dev branch 5 times, most recently from 3bf1747 to e1b3ddd Compare May 12, 2021 17:37

ShriramShastry requested a review from singalsu May 13, 2021 01:54

singalsu requested changes May 14, 2021

View reviewed changes

ShriramShastry force-pushed the shastry_cordiccos_dev branch from e1b3ddd to cbd20c9 Compare May 14, 2021 12:04

singalsu reviewed May 14, 2021

View reviewed changes

src/include/sof/math/trig.h Outdated Show resolved Hide resolved

ShriramShastry force-pushed the shastry_cordiccos_dev branch from cbd20c9 to 324697a Compare May 14, 2021 15:59

ShriramShastry requested review from paulstelian97 and singalsu May 14, 2021 16:46

singalsu reviewed May 17, 2021

View reviewed changes

src/include/sof/math/trig.h Outdated Show resolved Hide resolved

ShriramShastry force-pushed the shastry_cordiccos_dev branch from 324697a to d5e2273 Compare May 17, 2021 11:39

singalsu approved these changes May 17, 2021

View reviewed changes

ShriramShastry requested a review from singalsu May 17, 2021 12:25

singalsu approved these changes May 17, 2021

View reviewed changes

slawblauciak approved these changes May 17, 2021

View reviewed changes

lgirdwood reviewed May 19, 2021

View reviewed changes

lgirdwood merged commit 845c278 into main May 19, 2021

lgirdwood deleted the shastry_cordiccos_dev branch May 19, 2021 10:00

singalsu mentioned this pull request May 19, 2021

[BUG] Reduce footprint by putting large items under kconfig options #3480

Closed

4 tasks

Comments

Conversation

ShriramShastry commented Apr 19, 2021

Uh oh!

cujomalainey left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ShriramShastry commented Apr 20, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

paulstelian97 commented Apr 20, 2021

Uh oh!

ShriramShastry commented Apr 20, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

paulstelian97 commented Apr 20, 2021

Uh oh!

ShriramShastry commented Apr 20, 2021

Uh oh!

Uh oh!

Uh oh!

paulstelian97 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

singalsu left a comment

Choose a reason for hiding this comment

Uh oh!

singalsu left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lgirdwood May 19, 2021

Choose a reason for hiding this comment

Uh oh!

ShriramShastry May 20, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lgirdwood May 19, 2021

Choose a reason for hiding this comment

Uh oh!

ShriramShastry May 20, 2021

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

ShriramShastry commented Apr 20, 2021 •

edited

Loading

singalsu left a comment •

edited

Loading

ShriramShastry May 20, 2021 •

edited

Loading