lib.sh: add detailed description of func_lib_start_log_collect() #906
Merged
marc-hb merged 2 commits intothesofproject:mainfrom May 16, 2022
Merged
lib.sh: add detailed description of func_lib_start_log_collect() #906marc-hb merged 2 commits intothesofproject:mainfrom
marc-hb merged 2 commits intothesofproject:mainfrom
Conversation
Fixes commit dab6da8 ("lib.sh: disable sof-logger when running IPC4 mode (thesofproject#884)") Signed-off-by: Marc Herbert <marc.herbert@intel.com>
This is becoming required because Zephyr logging is adding another layer of complexity, See for instance thesofproject#897 work in progress. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Collaborator
Author
|
https://sof-ci.01.org/softestpr/PR906/build26/devicetest has some IPC4 growing pains on some platforms that are totally unrelated to this simple comment addition. Other platforms all PASSed. |
Collaborator
Author
|
SOFCI TEST |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is becoming required because Zephyr logging is adding another layer
of complexity, See for instance
#897 work in progress.
Signed-off-by: Marc Herbert marc.herbert@intel.com