lib.sh: disable sof-logger when running IPC4 mode#884
lib.sh: disable sof-logger when running IPC4 mode#884XiaoyunWu6666 merged 1 commit intothesofproject:mainfrom
Conversation
|
this can replace PR https://github.com/intel-innersource/drivers.audio.ci.sof-sh/pull/53 and https://github.com/intel-innersource/drivers.audio.ci.sof-framework/pull/202. |
1fc52a0 to
94b83ed
Compare
case-lib/lib.sh
Outdated
| { | ||
| local ipc_type | ||
|
|
||
| ipcFile=/sys/module/snd_sof_pci/parameters/ipc_type |
6694d86 to
a38a81d
Compare
Currently, sof-logger is not supported when running IPC4 mode. Thus, disable SOF logs collection globally when DUT runs IPC4 mode. This should be removed after sof-logger support for IPC4 has been provided. Signed-off-by: Xiaoyun Wu(Iris) <xiaoyun.wu@intel.com>
|
test result on DUT is as expected |
@plbossart please correct me: I think this is wrong. sof-logger is not supported when running cAVS firmware. It should be supported when running open-source IPC4. If a test fails with IPC4, how is the bug going to be identified without logs? |
|
@marc-hb I think the kernel doesn't setup debugfs for SOF under IPC4, so sof-logger can not work. |
| # TODO: | ||
| # Need to remove disabling sof-logger | ||
| # after sof-logger support for IPC4 has been provided in the future | ||
| dlogi 'Currenly sof-logger is not supported when running IPC4 mode' |
There was a problem hiding this comment.
Currenly should be Currently.
Sorry I didn't respond before the PR was merged.
Fixes commit dab6da8 ("lib.sh: disable sof-logger when running IPC4 mode (thesofproject#884)") Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Currently, sof-logger is not supported when running IPC4 mode.
Thus, disable SOF logs collection globally when DUT runs IPC4 mode (this can be telled by system file /sys/module/snd_sof_pci/parameters/ipc_type).
This should be removed after sof-logger support for IPC4 has been provided.
Signed-off-by: Xiaoyun Wu(Iris) xiaoyun.wu@intel.com