Skip to content

fixed Error when trying to set boolean field to false on google_data_catalog_tag#84

Merged
modular-magician merged 1 commit into
terraform-google-modules:masterfrom
modular-magician:downstream-pr-96ce577810a713390d312d5974ca81765533d2c7
Sep 10, 2020
Merged

fixed Error when trying to set boolean field to false on google_data_catalog_tag#84
modular-magician merged 1 commit into
terraform-google-modules:masterfrom
modular-magician:downstream-pr-96ce577810a713390d312d5974ca81765533d2c7

Conversation

@modular-magician
Copy link
Copy Markdown
Collaborator

@modular-magician modular-magician commented Sep 10, 2020

Fixes hashicorp/terraform-provider-google#7097

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

datacatalog: fixed error when trying to set `bool_value` to false on `google_data_catalog_tag`

Derived from GoogleCloudPlatform/magic-modules#3910

@modular-magician
fixed Error when trying to set boolean field to false on google_dat…
68a2ec1 
…a_catalog_tag (#3910)

* add test for false vale for datacatlog tag

* Update transport.go

* Update api.yaml

* Update terraform.yaml

add skip_docs: true for the example

Co-authored-by: Edward Sun <sunedward@google.com>
Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 3807973 into terraform-google-modules:master Sep 10, 2020
@modular-magician modular-magician deleted the downstream-pr-96ce577810a713390d312d5974ca81765533d2c7 branch November 18, 2024 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Error when trying to set boolean field to false on google_data_catalog_tag

1 participant

@modular-magician