fixed Error when trying to set boolean field to false on google_data_catalog_tag

[edwardmedia]

Fixes hashicorp/terraform-provider-google#7097

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

datacatalog: fixed error when trying to set `bool_value` to false on `google_data_catalog_tag`

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 170 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 3 files changed, 170 insertions(+), 1 deletion(-))
TF Conversion: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
TF OiCS: Diff ( 4 files changed, 165 insertions(+))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=142309"

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccActiveDirectoryDomainTrust_activeDirectoryDomainTrustBasicExample|TestAccBigQueryJob_bigqueryJobLoadExample|TestAccBigQueryJob_bigqueryJobLoadTableReferenceExample|TestAccBigQueryJob_bigqueryJobExtractExample|TestAccAccessContextManager|TestAccBigQueryJob_bigqueryJobExtractTableReferenceExample|TestAccBigqueryReservationReservation_bigqueryReservationBasicExample|TestAccBigqueryReservationReservation_bigqueryReservation|TestAccAppEngineFlexibleAppVersion_appEngineFlexibleAppVersionExample|TestAccAppEngineFlexibleAppVersion_update|TestAccCloudBuildTrigger_cloudbuildTriggerFilenameExample|TestAccCloudBuildTrigger_cloudbuildTriggerBuildExample|TestAccCloudIotDevice_cloudiotDeviceFullExample|TestAccCloudIoTDevice_update|TestAccCloudRunDomainMapping_cloudRunDomainMappingBasicExample|TestAccCloudBuildTrigger_basic|TestAccCloudBuildTrigger_disable|TestAccBigqueryDataTransferConfig|TestAccCloudBuildTrigger_fullStep|TestAccComposerEnvironment_withDatabaseConfig|TestAccComposerEnvironment_withWebServerConfig|TestAccComposerEnvironment_update|TestAccComputeBackendBucket_basicModified|TestAccComputeBackendService_basic|TestAccComputeBackendService_withBackend|TestAccComputeBackendService_updatePreservesOptionalParameters|TestAccComputeBackendService_withBackendAndIAP|TestAccComputeBackendService_withConnectionDrainingAndUpdate|TestAccComputeBackendService_withSecurityPolicy|TestAccComputeBackendService_withSessionAffinity|TestAccComputeBackendService_withMaxConnections|TestAccComputeBackendService_withMaxConnectionsPerInstance|TestAccComputeBackendService_withMaxRatePerEndpoint|TestAccComputeBackendService_withCustomHeaders|TestAccComputeBackendService_trafficDirectorUpdateFull|TestAccComputeBackendService_withMaxConnectionsPerEndpoint|TestAccComputeBackendService_trafficDirectorUpdateBasic|TestAccComputeBackendService_withLogConfig|TestAccComputeForwardingRule_forwardingRuleHttpLbExample|TestAccComputeInstanceGroup_rename|TestAccComputeOrganizationSecurityPolicyRule_organizationSecurityPolicyRuleUpdateExample|TestAccComputeRegionBackendService_regionBackendServiceBalancingModeExample|TestAccComputeRegionBackendService_withBackendInternalManaged|TestAccComputeRegionBackendService_ilbUpdateFull|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupAppengineExample|TestAccComputeRegionTargetHttpProxy_regionTargetHttpProxyHttpsRedirectExample|TestAccComputeRegionUrlMap_regionUrlMapL7IlbPathExample|TestAccComputeRegionUrlMap_regionUrlMapL7IlbPathPartialExample|TestAccComputeRegionUrlMap_regionUrlMapL7IlbRouteExample|TestAccComputeRegionUrlMap_regionUrlMapL7IlbRoutePartialExample|TestAccComputeReservation_reservationBasicExample|TestAccComputeRegionUrlMap_defaultUrlRedirect|TestAccComputeReservation_update|TestAccComputeRegionUrlMap_ilbPathUpdate|TestAccComputeRegionUrlMap_ilbRouteUpdate|TestAccComputeSubnetwork_update|TestAccComputeTargetHttpProxy_targetHttpProxyHttpsRedirectExample|TestAccComputeUrlMap_urlMapTrafficDirectorRouteExample|TestAccComputeUrlMap_urlMapTrafficDirectorPathExample|TestAccComputeUrlMap_urlMapTrafficDirectorRoutePartialExample|TestAccComputeUrlMap_urlMapTrafficDirectorPathPartialExample|TestAccComputeUrlMap_urlMapParameterBasedRoutingExample|TestAccComputeUrlMap_urlMapHeaderBasedRoutingExample|TestAccComputeUrlMap_defaultUrlRedirect|TestAccComputeUrlMap_defaultRouteActionTrafficDirectorPathUpdate|TestAccComputeUrlMap_trafficDirectorUpdate|TestAccComputeUrlMap_defaultRouteActionTrafficDirectorUpdate|TestAccComputeUrlMap_trafficDirectorPathUpdate|TestAccComputeUrlMap_trafficDirectorRemoveRouteRule|TestAccDataCatalogTag_dataCatalogEntryTagFalseExample|TestAccDataCatalogTagTemplate_dataCatalogTagTemplateBasicExample|TestAccDataCatalogTag_dataCatalogEntryTagBasicExample|TestAccDataCatalogTag_dataCatalogEntryGroupTagExample|TestAccDataCatalogTag_update|TestAccDialogflowIntent_dialogflowIntentFullExample|TestAccDialogflowIntent_update|TestAccDialogflowAgent_update|TestAccDialogflowEntityType_update|TestAccHealthcareFhirStore_healthcareFhirStoreBasicExample|TestAccHealthcareFhirStore_healthcareFhirStoreStreamingConfigExample|TestAccHealthcareFhirStore_basic|TestAccHealthcareHl7V2Store_healthcareHl7V2StoreParserConfigExample|TestAccIdentityPlatformInboundSamlConfig_inboundSamlConfigUpdate|TestAccIdentityPlatformDefaultSupportedIdpConfig_defaultSupportedIdpConfigUpdate|TestAccIdentityPlatformTenantDefaultSupportedIdpConfig_identityPlatformTenantDefaultSupportedIdpConfigUpdate|TestAccIdentityPlatformOauthIdpConfig_identityPlatformOauthIdpConfigUpdate|TestAccIdentityPlatformTenantInboundSamlConfig_identityPlatformTenantInboundSamlConfigUpdate|TestAccIdentityPlatformTenantOauthIdpConfig_identityPlatformTenantOauthIdpConfigUpdate|TestAccIdentityPlatformTenant_identityPlatformTenantUpdate|TestAccMonitoringGroup_update|TestAccMonitoringUptimeCheckConfig_uptimeCheckConfigHttpExample|TestAccMonitoringUptimeCheckConfig_uptimeCheckConfigHttpsExample|TestAccMonitoringUptimeCheckConfig_update|TestAccMonitoringUptimeCheckConfig_changeNonUpdatableFields|TestAccOSConfigGuestPolicies_osConfigGuestPoliciesRecipesExample|TestAccOSConfigPatchDeployment_osConfigPatchDeploymentFullExample|TestAccOSConfigPatchDeployment_osConfigPatchDeploymentInstanceExample|TestAccPubsubSubscription_pubsubSubscriptionPullExample|TestAccPubsubSubscription_emptyTTL|TestAccPubsubSubscription_update You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=142312"

[google-cla]

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 171 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 4 files changed, 171 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 2 files changed, 2 insertions(+), 2 deletions(-))
TF OiCS: Diff ( 4 files changed, 165 insertions(+))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=142774"

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceComputeImage|TestAccComputeDiskIamBindingGenerated|TestAccComputeDiskIamMemberGenerated|TestAccComputeDiskIamPolicyGenerated|TestAccComputeRegionDiskIamBindingGenerated|TestAccComputeRegionDiskIamMemberGenerated|TestAccComputeRegionDiskIamPolicyGenerated|TestAccActiveDirectoryDomainTrust_activeDirectoryDomainTrustBasicExample|TestAccAppEngineFlexibleAppVersion_update|TestAccComputeAttachedDisk_basic|TestAccComputeAttachedDisk_full|TestAccComputeAttachedDisk_count|TestAccComputeDisk_diskBasicExample|TestAccComputeDiskResourcePolicyAttachment_diskResourcePolicyAttachmentBasicExample|TestAccComputeDiskResourcePolicyAttachment_update|TestAccComputeDisk_VSSWindows|TestAccComputeDisk_update|TestAccComputeDisk_fromSnapshot|TestAccComputeDisk_deleteDetach|TestAccComputeDisk_encryption|TestAccComputeDisk_resourcePolicies|TestAccComputeDisk_encryptionKMS|TestAccComputeImage_withLicense|TestAccComputeImage_basedondisk|TestAccComputeImage_sourceSnapshot|TestAccComputeInstanceFromTemplate_basic|TestAccComputeImage_resolveImage|TestAccComputeInstanceFromTemplate_overrideBootDisk|TestAccComputeInstanceFromTemplate_overrideAttachedDisk|TestAccComputeInstanceFromTemplate_overrideScheduling|TestAccComputeInstanceFromTemplate_overrideScratchDisk|TestAccComputeInstanceTemplate_disks|TestAccComputeInstanceTemplate_disksInvalid|TestAccComputeInstance_diskEncryption|TestAccComputeInstance_attachedDisk|TestAccComputeInstance_diskEncryptionRestart|TestAccComputeInstance_attachedDisk_sourceUrl|TestAccComputeInstance_attachedDisk_modeRo|TestAccComputeInstance_bootDisk_source|TestAccComputeInstance_bootDisk_sourceUrl|TestAccComputeInstance_attachedDiskUpdate|TestAccComputeInstance_kmsDiskEncryption|TestAccComputeInstance_private_image_family|TestAccComputeRegionDisk_regionDiskBasicExample|TestAccComputeRegionDisk_basic|TestAccComputeRegionDisk_basicUpdate|TestAccComputeRegionDiskResourcePolicyAttachment_regionDiskResourcePolicyAttachmentBasicExample|TestAccComputeRegionDisk_encryption|TestAccComputeRegionDisk_deleteDetach|TestAccComputeSnapshot_snapshotBasicExample|TestAccComputeSnapshot_encryption|TestAccDataCatalogTag_dataCatalogEntryTagBasicExample|TestAccDataCatalogTag_dataCatalogEntryGroupTagExample|TestAccDataCatalogTag_update|TestAccDataLossPreventionInspectTemplate_dlpInspectTemplateBasicExample|TestAccDataLossPreventionInspectTemplate_dlpInspectTemplateUpdate|TestAccDialogflowIntent_update|TestAccDialogflowAgent_update|TestAccDialogflowEntityType_update You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=142776"

[google-cla]

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 170 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 3 files changed, 170 insertions(+), 1 deletion(-))
TF Conversion: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
TF OiCS: Diff ( 4 files changed, 165 insertions(+))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=142820"

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 170 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 3 files changed, 170 insertions(+), 1 deletion(-))
TF Conversion: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
TF OiCS: Diff ( 4 files changed, 165 insertions(+))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=142821"

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceComputeImage|TestAccComputeDiskIamBindingGenerated|TestAccComputeDiskIamMemberGenerated|TestAccComputeDiskIamPolicyGenerated|TestAccComputeRegionDiskIamBindingGenerated|TestAccComputeRegionDiskIamPolicyGenerated|TestAccActiveDirectoryDomainTrust_activeDirectoryDomainTrustBasicExample|TestAccBigQueryJob_bigqueryJobLoadExample|TestAccBigQueryJob_bigqueryJobLoadTableReferenceExample|TestAccAccessContextManager|TestAccBigQueryJob_bigqueryJobExtractExample|TestAccBigQueryJob_bigqueryJobExtractTableReferenceExample|TestAccBigqueryReservationReservation_bigqueryReservationBasicExample|TestAccBigqueryReservationReservation_bigqueryReservation|TestAccAppEngineFlexibleAppVersion_appEngineFlexibleAppVersionExample|TestAccCloudBuildTrigger_cloudbuildTriggerFilenameExample|TestAccCloudBuildTrigger_cloudbuildTriggerBuildExample|TestAccCloudIotDevice_cloudiotDeviceFullExample|TestAccCloudIoTDevice_update|TestAccCloudRunDomainMapping_cloudRunDomainMappingBasicExample|TestAccCloudBuildTrigger_basic|TestAccCloudBuildTrigger_disable|TestAccCloudBuildTrigger_fullStep|TestAccBigqueryDataTransferConfig|TestAccComputeBackendBucket_basicModified|TestAccComputeBackendService_basic|TestAccComputeBackendService_withBackend|TestAccComputeBackendService_updatePreservesOptionalParameters|TestAccComputeBackendService_withConnectionDrainingAndUpdate|TestAccComputeBackendService_withBackendAndIAP|TestAccComputeBackendService_withSessionAffinity|TestAccComputeBackendService_withSecurityPolicy|TestAccComputeDisk_diskBasicExample|TestAccComputeBackendService_withMaxConnections|TestAccComputeBackendService_withMaxConnectionsPerInstance|TestAccComputeDiskResourcePolicyAttachment_diskResourcePolicyAttachmentBasicExample|TestAccComputeBackendService_withMaxRatePerEndpoint|TestAccComputeBackendService_withCustomHeaders|TestAccComputeBackendService_withLogConfig|TestAccComputeBackendService_trafficDirectorUpdateBasic|TestAccComputeBackendService_trafficDirectorUpdateFull|TestAccComputeDiskResourcePolicyAttachment_update|TestAccComputeDisk_VSSWindows|TestAccComputeDisk_update|TestAccComputeBackendService_withMaxConnectionsPerEndpoint|TestAccComputeDisk_encryption|TestAccComputeDisk_deleteDetach|TestAccComputeDisk_resourcePolicies|TestAccComputeDisk_encryptionKMS|TestAccComputeForwardingRule_forwardingRuleHttpLbExample|TestAccComputeImage_withLicense|TestAccComputeImage_basedondisk|TestAccComputeImage_sourceSnapshot|TestAccComputeImage_resolveImage|TestAccComputeInstanceFromTemplate_basic|TestAccComputeInstanceFromTemplate_overrideBootDisk|TestAccComputeInstanceFromTemplate_overrideAttachedDisk|TestAccComputeInstanceFromTemplate_overrideScheduling|TestAccComputeInstanceFromTemplate_overrideScratchDisk|TestAccComputeInstanceGroup_rename|TestAccComputeInstanceTemplate_disks|TestAccComputeInstanceTemplate_disksInvalid|TestAccComputeInstance_diskEncryption|TestAccComputeInstance_diskEncryptionRestart|TestAccComputeInstance_attachedDisk|TestAccComputeInstance_attachedDisk_modeRo|TestAccComputeInstance_attachedDisk_sourceUrl|TestAccComputeInstance_bootDisk_source|TestAccComputeInstance_bootDisk_sourceUrl|TestAccComputeInstance_kmsDiskEncryption|TestAccComputeOrganizationSecurityPolicyRule_organizationSecurityPolicyRuleUpdateExample|TestAccComputeRegionBackendService_regionBackendServiceBalancingModeExample|TestAccComputeRegionBackendService_withBackendInternalManaged|TestAccComputeRegionDisk_regionDiskBasicExample|TestAccComputeRegionDisk_basicUpdate|TestAccComputeRegionDiskResourcePolicyAttachment_regionDiskResourcePolicyAttachmentBasicExample|TestAccComputeRegionBackendService_ilbUpdateFull|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupAppengineExample|TestAccComputeRegionTargetHttpProxy_regionTargetHttpProxyHttpsRedirectExample|TestAccComputeRegionUrlMap_regionUrlMapL7IlbPathExample|TestAccComputeRegionUrlMap_regionUrlMapL7IlbPathPartialExample|TestAccComputeRegionUrlMap_regionUrlMapL7IlbRoutePartialExample|TestAccComputeRegionUrlMap_regionUrlMapL7IlbRouteExample|TestAccComputeRegionUrlMap_defaultUrlRedirect|TestAccComputeReservation_reservationBasicExample|TestAccComputeReservation_update|TestAccComputeRegionUrlMap_ilbPathUpdate|TestAccComputeRegionUrlMap_ilbRouteUpdate|TestAccComputeTargetHttpProxy_targetHttpProxyHttpsRedirectExample|TestAccComputeSubnetwork_update|TestAccComputeUrlMap_urlMapTrafficDirectorRouteExample|TestAccComputeUrlMap_urlMapTrafficDirectorRoutePartialExample|TestAccComputeUrlMap_urlMapTrafficDirectorPathExample|TestAccComputeUrlMap_urlMapTrafficDirectorPathPartialExample|TestAccComputeUrlMap_urlMapHeaderBasedRoutingExample|TestAccComputeUrlMap_urlMapParameterBasedRoutingExample|TestAccComputeUrlMap_defaultUrlRedirect|TestAccComputeUrlMap_defaultRouteActionTrafficDirectorPathUpdate|TestAccComputeUrlMap_defaultRouteActionTrafficDirectorUpdate|TestAccComputeUrlMap_trafficDirectorUpdate You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=142823"

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 169 insertions(+))
Terraform Beta: Diff ( 2 files changed, 169 insertions(+))
TF Conversion: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
TF OiCS: Diff ( 4 files changed, 165 insertions(+))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=142824"

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 170 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 3 files changed, 170 insertions(+), 1 deletion(-))
TF Conversion: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
TF OiCS: Diff ( 4 files changed, 165 insertions(+))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=142824"

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeRegionDiskIamMemberGenerated|TestAccAppEngineFlexibleAppVersion_update|TestAccComputeAttachedDisk_basic|TestAccComputeAttachedDisk_full|TestAccComputeAttachedDisk_count|TestAccComputeDisk_VSSWindows|TestAccComputeDisk_fromSnapshot|TestAccComputeInstance_attachedDiskUpdate|TestAccComputeInstance_private_image_family|TestAccComputeRegionDisk_basic|TestAccComputeRegionDisk_encryption|TestAccComputeRegionDisk_deleteDetach|TestAccComputeSnapshot_snapshotBasicExample|TestAccComputeSnapshot_encryption|TestAccDataCatalogTag_dataCatalogEntryTagBasicExample|TestAccDataCatalogTag_dataCatalogEntryGroupTagExample|TestAccDataCatalogTag_update|TestAccDialogflowAgent_update You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=142826"

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 170 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 3 files changed, 170 insertions(+), 1 deletion(-))
TF Conversion: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
TF OiCS: Diff ( 4 files changed, 165 insertions(+))

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 96 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 2 files changed, 96 insertions(+), 1 deletion(-))
TF Conversion: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
TF OiCS: Diff ( 4 files changed, 165 insertions(+))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=144619"

[edwardmedia]

tpg-vcr-test failed. Likely it is timeout issue like the other case for google_cloudbuild_trigger

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 96 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 2 files changed, 96 insertions(+), 1 deletion(-))
TF Conversion: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
TF OiCS: Diff ( 4 files changed, 165 insertions(+))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=145004"

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 96 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 2 files changed, 96 insertions(+), 1 deletion(-))
TF Conversion: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
TF OiCS: Diff ( 4 files changed, 165 insertions(+))

[modular-magician]

I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=145006"

[modular-magician]

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceComputeBackendBucket_basic|TestAccDataSourceComputeImage|TestAccComputeDiskIamBindingGenerated|TestAccComputeDiskIamMemberGenerated|TestAccComputeDiskIamPolicyGenerated|TestAccComputeRegionDiskIamBindingGenerated|TestAccComputeRegionDiskIamMemberGenerated|TestAccComputeRegionDiskIamPolicyGenerated|TestAccComposerEnvironment_update|TestAccComposerEnvironment_private|TestAccComposerEnvironment_withDatabaseConfig|TestAccComposerEnvironment_withWebServerConfig|TestAccComputeAttachedDisk_basic|TestAccComputeAttachedDisk_full|TestAccComputeAttachedDisk_count|TestAccComputeBackendBucket_backendBucketBasicExample|TestAccComputeBackendBucketSignedUrlKey_basic|TestAccComputeBackendBucket_withCdnPolicy|TestAccComputeBackendService_basic|TestAccComputeBackendBucket_basicModified|TestAccComputeBackendService_updatePreservesOptionalParameters|TestAccComputeBackendService_withConnectionDrainingAndUpdate|TestAccComputeBackendService_withBackend|TestAccComputeBackendService_withBackendAndIAP|TestAccComputeBackendService_withSecurityPolicy|TestAccComputeBackendService_withSessionAffinity|TestAccComputeBackendService_withCustomHeaders|TestAccComputeBackendService_withMaxConnections|TestAccComputeBackendService_withMaxRatePerEndpoint|TestAccComputeBackendService_withMaxConnectionsPerInstance|TestAccComputeBackendService_withMaxConnectionsPerEndpoint|TestAccComputeBackendService_withLogConfig|TestAccComputeDisk_diskBasicExample|TestAccComputeBackendService_trafficDirectorUpdateBasic|TestAccComputeBackendService_trafficDirectorUpdateFull|TestAccComputeDisk_VSSWindows|TestAccComputeDiskResourcePolicyAttachment_diskResourcePolicyAttachmentBasicExample|TestAccComputeDiskResourcePolicyAttachment_update|TestAccComputeDisk_update|TestAccComputeDisk_fromSnapshot|TestAccComputeDisk_deleteDetach|TestAccComputeDisk_resourcePolicies|TestAccComputeDisk_encryption|TestAccComputeForwardingRule_forwardingRuleHttpLbExample|TestAccComputeDisk_encryptionKMS|TestAccComputeImage_withLicense|TestAccComputeImage_basedondisk|TestAccComputeImage_sourceSnapshot|TestAccComputeImage_resolveImage|TestAccComputeInstanceFromTemplate_overrideBootDisk|TestAccComputeInstanceFromTemplate_basic|TestAccComputeInstanceFromTemplate_overrideAttachedDisk|TestAccComputeInstanceFromTemplate_overrideScratchDisk|TestAccComputeInstanceFromTemplate_overrideScheduling|TestAccComputeInstanceGroup_rename|TestAccComputeInstanceTemplate_disks|TestAccComputeInstanceTemplate_disksInvalid|TestAccComputeInstance_diskEncryption|TestAccComputeInstance_attachedDisk|TestAccComputeInstance_diskEncryptionRestart|TestAccComputeInstance_attachedDisk_sourceUrl|TestAccComputeInstance_attachedDisk_modeRo|TestAccComputeInstance_bootDisk_source|TestAccComputeInstance_bootDisk_sourceUrl|TestAccComputeInstance_attachedDiskUpdate|TestAccComputeInstance_kmsDiskEncryption|TestAccComputeInstance_private_image_family|TestAccComputeOrganizationSecurityPolicyRule_organizationSecurityPolicyRuleUpdateExample|TestAccComputeRegionBackendService_regionBackendServiceBalancingModeExample|TestAccComputeRegionBackendService_ilbUpdateFull|TestAccComputeRegionBackendService_withBackendInternalManaged|TestAccComputeRegionDisk_regionDiskBasicExample|TestAccComputeRegionDiskResourcePolicyAttachment_regionDiskResourcePolicyAttachmentBasicExample|TestAccComputeRegionDisk_basic|TestAccComputeRegionDisk_basicUpdate|TestAccComputeRegionDisk_encryption|TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupAppengineExample|TestAccComputeRegionTargetHttpProxy_regionTargetHttpProxyHttpsRedirectExample|TestAccComputeRegionUrlMap_regionUrlMapL7IlbPathExample|TestAccComputeRegionUrlMap_regionUrlMapL7IlbPathPartialExample|TestAccComputeRegionUrlMap_regionUrlMapL7IlbRouteExample|TestAccComputeRegionUrlMap_regionUrlMapL7IlbRoutePartialExample|TestAccComputeRegionUrlMap_ilbPathUpdate|TestAccComputeRegionUrlMap_ilbRouteUpdate|TestAccComputeRegionUrlMap_defaultUrlRedirect|TestAccComputeReservation_reservationBasicExample|TestAccComputeReservation_update|TestAccComputeSnapshot_snapshotBasicExample|TestAccComputeSnapshot_encryptionCMEK|TestAccComputeSubnetwork_update|TestAccComputeTargetHttpProxy_targetHttpProxyHttpsRedirectExample|TestAccComputeUrlMap_urlMapTrafficDirectorRouteExample|TestAccComputeUrlMap_urlMapTrafficDirectorRoutePartialExample|TestAccComputeUrlMap_urlMapTrafficDirectorPathExample|TestAccComputeUrlMap_urlMapTrafficDirectorPathPartialExample|TestAccComputeUrlMap_urlMapHeaderBasedRoutingExample|TestAccComputeUrlMap_urlMapParameterBasedRoutingExample|TestAccComputeUrlMap_defaultRouteActionTrafficDirectorPathUpdate|TestAccComputeUrlMap_defaultRouteActionTrafficDirectorUpdate|TestAccComputeUrlMap_trafficDirectorUpdate You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=145007"

[nat-henderson]

This PR seems to have broken TestAccDataCatalogTag_*.

[nat-henderson]

Yes, confirmed - with this PR, all creates of these resources fail because it sends source.0.bool_value unconditionally, but only one field under source can be sent. Reverting - we'll need to find another way to address hashicorp/terraform-provider-google#7097. Maybe an expander?

[edwardmedia]

I see what happens.

{
 "column": "first_name",
 "fields": {
  "pii_type": {
   "boolValue": false,
   "enumValue": {
    "displayName": "NONE"
   }
  },
  "source": {
   "boolValue": false,
   "stringValue": "my-string"
  }
 },
 "template": "projects/myproject/locations/us-central1/tagTemplates/tf_test_my_templated2jfxsfx7o"
}

[nat-henderson]

Yeah, this will require a bit of special handling - we want to send the empty value if it is set in config, which we can only learn from d.GetOkExists(), which will require reworking of the template or some new kinds of custom code.

[edwardmedia]

One workaround for this issue is to override expandNestedDataCatalogTagFields() to make sure only one value will be assigned. To achieve this, shift the order of value assignments and put the boolValue to be the last. If any value assignment occurs before boolValue is hit, skip boolValue assignment.

[nat-henderson]

That's also a good idea. That could probably be done in an encoder.

[edwardmedia]

Implemented the fix using encoder #4004