Skip to content

add deletion_protection field for bigtable instance#45

Merged
modular-magician merged 1 commit into
terraform-google-modules:masterfrom
modular-magician:downstream-pr-dd24d60acc6fb2488c51f84f676f56d40cb6c18a
May 12, 2020
Merged

add deletion_protection field for bigtable instance#45
modular-magician merged 1 commit into
terraform-google-modules:masterfrom
modular-magician:downstream-pr-dd24d60acc6fb2488c51f84f676f56d40cb6c18a

Conversation

@modular-magician

Copy link
Copy Markdown
Collaborator

I called it allow_destroy to align with prevent_destroy and terraform destroy, but feel free to suggest a different name if you'd like.

I'm not considering this a breaking change because it doesn't affect users until they want to make a change, but let me know if you disagree.

Once this is merged, I'll follow up with the other bigtable resources.

EDIT: it's called deletion_protection now to align with the field in compute instance.

Release Note Template for Downstream PRs (will be copied)

* bigtable: added `deletion_protection` field to `google_bigtable_instance` to make deleting them require an explicit intent.
* `google_bigtable_instance` resources now cannot be destroyed unless `deletion_protection = false` is set in state for the resource.

Derived from GoogleCloudPlatform/magic-modules#3450

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 0dc6668 into terraform-google-modules:master May 12, 2020
@modular-magician modular-magician deleted the downstream-pr-dd24d60acc6fb2488c51f84f676f56d40cb6c18a branch November 18, 2024 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant