add deletion_protection field for bigtable instance#3450
Conversation
|
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 9 files changed, 104 insertions(+), 11 deletions(-)) |
|
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 9 files changed, 104 insertions(+), 11 deletions(-)) |
|
+riley for oics stuff |
rileykarson
left a comment
There was a problem hiding this comment.
OiCS changes lgtm- leaving clicking the approval button to @megan07
|
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 10 files changed, 196 insertions(+), 13 deletions(-)) |
1 similar comment
|
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 10 files changed, 196 insertions(+), 13 deletions(-)) |
|
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 10 files changed, 196 insertions(+), 13 deletions(-)) |
I called it
allow_destroyto align withprevent_destroyandterraform destroy, but feel free to suggest a different name if you'd like.I'm not considering this a breaking change because it doesn't affect users until they want to make a change, but let me know if you disagree.
Once this is merged, I'll follow up with the other bigtable resources.
EDIT: it's called deletion_protection now to align with the field in compute instance.
Release Note Template for Downstream PRs (will be copied)