Non-recursive failure handling in HttpClient.exec()#95
Closed
theoreticalbts wants to merge 1 commit intomasterfrom
Closed
Non-recursive failure handling in HttpClient.exec()#95theoreticalbts wants to merge 1 commit intomasterfrom
theoreticalbts wants to merge 1 commit intomasterfrom
Conversation
Contributor
|
Thanks for the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where occasionally
steem-pythonwill revert to positional argument passing when RPC methods are called with keyword arguments. The bug occurs when retrying after a failure of the server RPC connection. The existing implementation has a recursive tail call toexecbut PR #86 did not update the tail call to forward the newkwargsargument.This patch refactors the recursive tail call to use a loop instead, which has the following desirable properties:
nsuccessive connection failures do not consumenstack framesAdding
?w=1to the URL to suppress whitespace will make this pull request easier to review, this patch is like a textbook example of replacing recursion with iteration.