Closed
Conversation
Proposal to implement similar error checking logic when a non 200 error code is received. This will reduce/avoid empty responses. In the current state, there is a loop to infinity condition when using the Steemd function "get_blocks" if the active RPC node persistently returns a non 200 error code. For many other functions performing an API call, this should reduce the number of exceptions thrown due to empty responses. Please review. Have seen no negative effects in my tests so far.
|
Yes, this was giving me headaches, so I have been creating my own work-around. Would be great if this could be merged in with #95 as well. |
Contributor
|
This is implemented in #202 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposal to implement similar error checking logic when a non 200 error code is received. This will reduce/avoid empty responses.
In the current state, there is a loop to infinity condition when using the Steemd function "get_blocks" if the active RPC node persistently returns a non 200 error code.
For many other functions performing an API call, this should reduce the number of exceptions thrown due to empty responses.
Please review.
Have seen no negative effects in my tests so far.