This repository was archived by the owner on Jul 10, 2021. It is now read-only.

Renamed titles, added links and improved wording#1964

Closed

aleon1220 wants to merge 9 commits intospinnaker:masterfrom

aleon1220:patch-4

Contributor

aleon1220 commented Jul 22, 2020

changed the title for the 3 options on how to set up AWS IAM structure
1-with CF console
2-With AWS CLI
3-with the AWS IAM console
Listed the main components of the AWS IAM structure
In halyard section changed titles to put them in context by using the AWS provider.
I changed the wording to start with actions to perform e.g. Enable the AWS Provider

In Next steps section
I added links to the other AWS compute services: ECS, EKS and lambda


          renamed titles and added links

ddb187b

changed the title for the 3 options on how to set up AWS IAM structure
1-with CF console
2-With AWS CLI
3-with the AWS IAM console
Listed the main components of the AWS IAM structure
In halyard section changed titles to put them in context by using the AWS provider.
I changed the wording to start with actions to perform e.g. Enable the AWS Provider

In Next steps section
I added links to the other AWS compute services: ECS, EKS and lambda

dorbin reviewed

View reviewed changes

Contributor

dorbin left a comment

Nice! I left a bunch of edits though. :)

setup/install/providers/aws/aws-ec2.md Outdated Show resolved Hide resolved

setup/install/providers/aws/aws-ec2.md


		Spinnaker will use an [AWS IAM structure](https://aws.amazon.com/iam/) of users, roles, policies, etc to access AWS services and resources securely. There are 3 options to set up the AWS IAM structure

		1. AWS CloudFormation templates deployed with the CloudFormation Console

Contributor

dorbin Jul 22, 2020

Maybe hyperlink these to their respective headings below?

Contributor

dorbin Jul 23, 2020

I meant link each of these three list items to the headings below, in the article (though with headings like these, the auto-generated anchor will be complex. The current anchor for option 1 (on the published site, before these changes) is #option-1--use-aws-console-to-configure-aws

setup/install/providers/aws/aws-ec2.md Outdated Show resolved Hide resolved

setup/install/providers/aws/aws-ec2.md Outdated Show resolved Hide resolved

setup/install/providers/aws/aws-ec2.md

               ```
-              ## Option-3 : Use AWS Console UI (Manual Steps)
+              ## Option-3 : Configure with AWS IAM Console

Contributor

dorbin Jul 22, 2020

Suggested change

      
            ## Option-3 : Configure with AWS IAM Console
          
            ## Option 3: Configure with AWS IAM Console

setup/install/providers/aws/aws-ec2.md Show resolved Hide resolved

setup/install/providers/aws/aws-ec2.md Outdated Show resolved Hide resolved

setup/install/providers/aws/aws-ec2.md

-              You can view the available configuration flags for AWS within the
-              [Halyard reference](/reference/halyard/commands#hal-config-provider-aws-account-add).
+              You can view the available configuration flags for Spinnaker AWS provider within the

Contributor

dorbin Jul 22, 2020

Suggested change

      
            You can view the available configuration flags for Spinnaker AWS provider within the
          
            You can view the available configuration flags for the Spinnaker AWS provider in the

setup/install/providers/aws/aws-ec2.md Outdated Show resolved Hide resolved

setup/install/providers/aws/aws-ec2.md Outdated Show resolved Hide resolved

aleon1220 and others added 6 commits

July 23, 2020 10:54


          Update setup/install/providers/aws/aws-ec2.md

cfd72ad

great. Thanks

Co-authored-by: Dave Dorbin <ddorbin@google.com>


          Update setup/install/providers/aws/aws-ec2.md

9f2794e

Co-authored-by: Dave Dorbin <ddorbin@google.com>


          Update setup/install/providers/aws/aws-ec2.md

4ac6a46

agree is best to remove extra character

Co-authored-by: Dave Dorbin <ddorbin@google.com>


          Update setup/install/providers/aws/aws-ec2.md

ce94f62

agree.

Co-authored-by: Dave Dorbin <ddorbin@google.com>


          Update setup/install/providers/aws/aws-ec2.md

dacc2a9

yes.

Co-authored-by: Dave Dorbin <ddorbin@google.com>


          Added bulletpoints for Next Steps

3853f97

Added bullet points
Changed wording to include words "With Spinnaker" great for search engines
changed wording in the last line

aleon1220 commented

View reviewed changes

Contributor Author

aleon1220 left a comment

updated changes.


          Merge branch 'master' into patch-4

b17357d

Contributor Author

aleon1220 commented Jul 22, 2020

@dorbin Thanks Dave for your suggestions. I have planned some extra improvements to the complete AWS Provider (EC2, ECS, EKS, Lambda). I have been doing progressively and in small chunks. Thanks.
If you have improvement ideas i am happy to read about them.

aleon1220 requested a review from dorbin

July 23, 2020 02:27


          Merge branch 'master' into patch-4

401ef5f

dorbin approved these changes

View reviewed changes

dorbin added the ready to merge label

mergify bot added the auto merged label

ezimanyi removed the ready to merge label

aleon1220 added a commit to aleon1220/spinnaker.github.io that referenced this pull request


          branch patch from PR1964

0ba8453

Something happened in [PR1964](spinnaker#1964) i am readding the changes and re-committing them.
Please help @dorbin @brian-armory

aleon1220 mentioned this pull request

docs(aws): AWS EC2 provider instructions, diagram and code for manual AWS IAM set up. #1996

Merged

Contributor Author

aleon1220 commented Aug 7, 2020

OK I have created a new PR #1996 with the changes from this PR1964
Hopefully it can be easily merged...

aleon1220 closed this

dorbin added a commit that referenced this pull request


          docs(aws): AWS EC2 provider instructions, diagram and code for manual…

fbfd466

… AWS IAM set up. (#1996)

* branch patch from PR1964

Something happened in [PR1964](#1964) i am readding the changes and re-committing them.
Please help @dorbin @brian-armory

* Update setup/install/providers/aws/aws-ec2.md

great suggestion thanks.

Co-authored-by: Dave Dorbin <ddorbin@google.com>

* Update setup/install/providers/aws/aws-ec2.md

grammar fix

Co-authored-by: Dave Dorbin <ddorbin@google.com>

* Improved wording and removed redundant line.

* Adds instructions with an example
the instructions allow Spinnaker operators to
deploy to AWS Accounts develop and staging.
arranged the wording of the instructions.

* Adds the AWS provider diagram with extension .drawio
The diagram can be opened online with https://www.draw.io/

* Adds the image in .svg format for the example
The example shows an architecture with 3 AWS accounts
1 Spinnaker Managing where Spinnaker Lives
2 develop
3 staging

* Fixes anchor link to new section AWS IAM user or roles

* Update setup/install/providers/aws/aws-ec2.md

Great suggestion

Co-authored-by: Dave Dorbin <ddorbin@google.com>

* Update setup/install/providers/aws/aws-ec2.md

simple and concise. Thanks

Co-authored-by: Dave Dorbin <ddorbin@google.com>

* Update setup/install/providers/aws/aws-ec2.md

grammar fix.

Co-authored-by: Dave Dorbin <ddorbin@google.com>

* Update setup/install/providers/aws/aws-ec2.md

grammar fix

Co-authored-by: Dave Dorbin <ddorbin@google.com>

* Merges parts from PR2020

* WIP edits

* edits

* Update setup/install/providers/aws/aws-ec2.md

* Update setup/install/providers/aws/aws-ec2.md

* fix anchor link

* minor fixes and improved the halyard example to enable the AWS provider

* fix indent

Co-authored-by: Dave Dorbin <ddorbin@google.com>
Co-authored-by: Andres Leon-Rangel <aleonrangel@deref.nz>
Co-authored-by: brian-armory <53799971+brian-armory@users.noreply.github.com>
Co-authored-by: brian-armory <brian.le@armory.io>

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels