Skip to content

Move attachment_gw app under backend/attachment_gw/#6626

Merged
pashiav merged 8 commits into
issue-6571from
issue-6624
Jul 16, 2025
Merged

Move attachment_gw app under backend/attachment_gw/#6626
pashiav merged 8 commits into
issue-6571from
issue-6624

Conversation

@pashiav

@pashiav pashiav commented Jun 11, 2025

Copy link
Copy Markdown
Contributor

Fixes #6624

This PR reorganizes the project structure by moving the attachment_gw app into a new backend/attachment_gw/ directory under specifyweb/.

Summary of Changes:

  • Moved attachment_gw to specifyweb/backend/attachment_gw/
  • Updated all import paths to reflect the new location
  • Updated SPECIFY_APPS in settings.py to include specifyweb.backend.attachment_gw

This is the 3rd PR in a broader backend reorganization. No frontend behavior or functionality was changed.

Notes:

Checklist

  • Self-review the PR after opening it to make sure the changes look good and
    self-explanatory (or properly documented)
  • Add relevant issue to release milestone
  • Add pr to documentation list
  • Add automated tests
  • Add a reverse migration if a migration is present in the PR

Testing instructions

Please cross check the following functionalities with main.

  • General Attachment testing (additional gen testing in addition to the ones below)

    Verify that you can:

    Record Attachments:

    • Upload/Add different types of attachments to a record (e.g. video, audio, image, presentation, documents)
    • Open an attachment in a new tab
    • Delete an attachment
    • Download an attachment through the Attachments popup
    • Download All attachments through the Attachments popup

    Batch Image Upload:

    • Add several different attachments (e.g. video, audio, image, presentation, documents)
    • Use this image (from v7.11 checklist) to pick 3 paths to upload to:
    Screenshot 2025-06-18 at 10 33 16 AM
    • Validate data set
    • Upload data set
    • Use links to view records & verify that images are attached
    • Roll back data set
    • Interrupt upload after a bit and check that only some files were uploaded

    Workbench:

    • Import a valid dataset
    • Check correctness of imported dataset

@pashiav pashiav linked an issue Jun 11, 2025 that may be closed by this pull request
@github-project-automation github-project-automation Bot moved this to 📋Back Log in General Tester Board Jun 11, 2025
@pashiav
pashiav changed the base branch from main to issue-6615 June 11, 2025 19:18
@pashiav pashiav added this to the 7.12.0 milestone Jun 11, 2025
@pashiav pashiav self-assigned this Jun 11, 2025
@pashiav
pashiav marked this pull request as ready for review June 18, 2025 15:45
@pashiav
pashiav requested review from a team and CarolineDenis June 18, 2025 15:45

@emenslin emenslin left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing instructions

Please cross check the following functionalities with main.

  • General Attachment testing

    • Upload/Add different types of attachments to a record (e.g. video, audio, image, presentation, documents)
    • Open an attachment in a new tab
    • Delete an attachment
    • Download an attachment through the Attachments popup
    • Download All attachments through the Attachments popup

    Batch Image Upload:

    • Add several different attachments (e.g. video, audio, image, presentation, documents)
    • Use this image (from v7.11 checklist) to pick 3 paths to upload to:
    Screenshot 2025-06-18 at 10 33 16 AM
    • Validate data set
    • Upload data set
    • Use links to view records & verify that images are attached
    • Roll back data set
    • Interrupt upload after a bit and check that only some files were uploaded

    Workbench:

    • Import a valid dataset
    • Check correctness of imported dataset

Looks good, the only thing I ran into is I'm having a bit of trouble loading large workbench datasets. In main the dataset is loading in just fine and I can scroll through all the rows without problems but in the issue branch it is having some problems. Could be unrelated and the dataset does eventually load in fine on the issue branch but it is something I wanted to make note of.

Issue branch:

07-02_10.20.mp4

Main:

07-02_10.21.mp4

@emenslin
emenslin requested a review from a team July 2, 2025 15:24
Base automatically changed from issue-6615 to issue-6571 July 16, 2025 15:47

@lexiclevenger lexiclevenger left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing instructions

Please cross check the following functionalities with main.

  • General Attachment testing (additional gen testing in addition to the ones below)

    • Upload/Add different types of attachments to a record (e.g. video, audio, image, presentation, documents)
    • Open an attachment in a new tab
    • Delete an attachment
    • Download an attachment through the Attachments popup
    • Download All attachments through the Attachments popup
    • Add several different attachments (e.g. video, audio, image, presentation, documents)
    • Use this image (from v7.11 checklist) to pick 3 paths to upload to:
    Screenshot 2025-06-18 at 10 33 16 AM
    • Validate data set
    • Upload data set
    • Use links to view records & verify that images are attached
    • Roll back data set
    • Interrupt upload after a bit and check that only some files were uploaded
    • Import a valid dataset
    • Check correctness of imported dataset

Looks good! I didn't see any issues with attachments. I also didn't notice a difference in WB behaviors.

@pashiav
pashiav merged commit 0a74d74 into issue-6571 Jul 16, 2025
14 checks passed
@github-project-automation github-project-automation Bot moved this from 📋Back Log to ✅Done in General Tester Board Jul 16, 2025
@pashiav
pashiav deleted the issue-6624 branch July 16, 2025 20:50
@CarolineDenis CarolineDenis modified the milestones: 7.12.0, 7.11.2 Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅Done

Development

Successfully merging this pull request may close these issues.

Reorganize attachment_gw app under backend/attachment_gw/

4 participants