Move attachment_gw app under backend/attachment_gw/#6626
Conversation
emenslin
left a comment
There was a problem hiding this comment.
Testing instructions
Please cross check the following functionalities with main.
-
General Attachment testing
- Upload/Add different types of attachments to a record (e.g. video, audio, image, presentation, documents)
- Open an attachment in a new tab
- Delete an attachment
- Download an attachment through the Attachments popup
- Download All attachments through the Attachments popup
Batch Image Upload:
- Add several different attachments (e.g. video, audio, image, presentation, documents)
- Use this image (from v7.11 checklist) to pick 3 paths to upload to:
- Validate data set
- Upload data set
- Use links to view records & verify that images are attached
- Roll back data set
- Interrupt upload after a bit and check that only some files were uploaded
Workbench:
- Import a valid dataset
- Check correctness of imported dataset
Looks good, the only thing I ran into is I'm having a bit of trouble loading large workbench datasets. In main the dataset is loading in just fine and I can scroll through all the rows without problems but in the issue branch it is having some problems. Could be unrelated and the dataset does eventually load in fine on the issue branch but it is something I wanted to make note of.
Issue branch:
07-02_10.20.mp4
Main:
07-02_10.21.mp4
Triggered by 36a05ed on branch refs/heads/issue-6624
lexiclevenger
left a comment
There was a problem hiding this comment.
Testing instructions
Please cross check the following functionalities with main.
-
General Attachment testing (additional gen testing in addition to the ones below)
- Upload/Add different types of attachments to a record (e.g. video, audio, image, presentation, documents)
- Open an attachment in a new tab
- Delete an attachment
- Download an attachment through the Attachments popup
- Download All attachments through the Attachments popup
- Add several different attachments (e.g. video, audio, image, presentation, documents)
- Use this image (from v7.11 checklist) to pick 3 paths to upload to:
- Validate data set
- Upload data set
- Use links to view records & verify that images are attached
- Roll back data set
- Interrupt upload after a bit and check that only some files were uploaded
- Import a valid dataset
- Check correctness of imported dataset
Looks good! I didn't see any issues with attachments. I also didn't notice a difference in WB behaviors.
Fixes #6624
This PR reorganizes the project structure by moving the
attachment_gwapp into a newbackend/attachment_gw/directory underspecifyweb/.Summary of Changes:
attachment_gwtospecifyweb/backend/attachment_gw/SPECIFY_APPSinsettings.pyto includespecifyweb.backend.attachment_gwThis is the 3rd PR in a broader backend reorganization. No frontend behavior or functionality was changed.
Notes:
permissionsapp underbackend/permissions/#6618.Checklist
self-explanatory (or properly documented)
Testing instructions
Please cross check the following functionalities with
main.General Attachment testing (additional gen testing in addition to the ones below)
Verify that you can:
Record Attachments:
Batch Image Upload:
Workbench: