Skip to content

Move permissions app under backend/permissions/#6618

Merged
pashiav merged 15 commits into
issue-6571from
issue-6615
Jul 16, 2025
Merged

Move permissions app under backend/permissions/#6618
pashiav merged 15 commits into
issue-6571from
issue-6615

Conversation

@pashiav

@pashiav pashiav commented Jun 10, 2025

Copy link
Copy Markdown
Contributor

Fixes #6615

This PR reorganizes the project structure by moving the permissions app into a new backend/permissions/ directory under specifyweb/.

Summary of Changes:

  • Moved permissions to specifyweb/backend/permissions/
  • Updated all import paths to reflect the new location
  • Updated SPECIFY_APPS in settings.py to include specifyweb.backend.permissions

This is the 2nd PR in a broader backend reorganization. No frontend behavior or functionality was changed.

Notes:

Checklist

  • Self-review the PR after opening it to make sure the changes look good and
    self-explanatory (or properly documented)
  • Add relevant issue to release milestone
  • Add relevant documentation (Tester - Dev)
  • Add automated tests
  • Add a reverse migration if a migration is present in the PR

Testing instructions

See more info on Permissions

Please cross check the following functionalities with main.

  • General Permissions testing
    Verify that you can:
    • Create new Role from Library
    • Create new Role from existing Role
    • Create completely new Role
    • Import Roles
    • Export Roles
    • Edit Name/Description fields on User Roles
    • Delete a Role
    • Create a role that grants edit access and assign it to a user
    • Apply custom collection-level policies to a user
    • Test the policies and roles you apply to a user
    • Verify permissions are still enforced correctly in Workbench
      • Validate & Upload a valid dataset
    • Verify permissions are still enforced correctly in Queries

@pashiav pashiav added this to the 7.12.0 milestone Jun 10, 2025
@pashiav pashiav self-assigned this Jun 10, 2025
@pashiav pashiav linked an issue Jun 10, 2025 that may be closed by this pull request
@github-project-automation github-project-automation Bot moved this to 📋Back Log in General Tester Board Jun 10, 2025
@pashiav pashiav moved this from 📋Back Log to (✌゚∀゚)☞ Pashia Testing in General Tester Board Jun 10, 2025
@pashiav pashiav moved this from (✌゚∀゚)☞ Pashia Testing to 📋Back Log in General Tester Board Jun 10, 2025
@pashiav
pashiav marked this pull request as ready for review June 11, 2025 17:25
@pashiav
pashiav requested review from a team and CarolineDenis June 11, 2025 17:25
@pashiav
pashiav changed the base branch from main to issue-6571 June 11, 2025 17:33
@CarolineDenis
CarolineDenis changed the base branch from issue-6571 to main June 11, 2025 17:35
@pashiav
pashiav changed the base branch from main to issue-6571 June 11, 2025 17:41

@bhumikaguptaa bhumikaguptaa left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • General Permissions testing
    Verify that you can:
    • Create new Role from Library
    • Create new Role from existing Role
    • Create completely new Role
    • Import Roles
    • Export Roles
    • Edit Name/Description fields on User Roles
    • Delete a Role
    • Create a role that grants edit access and assign it to a user
    • Apply custom collection-level policies to a user
    • Test the policies and roles you apply to a user
    • Verify permissions are still enforced correctly in Workbench
      • Validate & Upload a valid dataset
    • Verify permissions are still enforced correctly in Queries

Works as expected!

@pashiav
pashiav requested a review from a team July 2, 2025 18:15

@emenslin emenslin left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing instructions

  • General Permissions testing
    • Create new Role from Library
    • Create new Role from existing Role
    • Create completely new Role
    • Import Roles
    • Export Roles
    • Edit Name/Description fields on User Roles
    • Delete a Role
    • Create a role that grants edit access and assign it to a user
    • Apply custom collection-level policies to a user
    • Test the policies and roles you apply to a user
    • Verify permissions are still enforced correctly in Workbench
      • Validate & Upload a valid dataset
    • Verify permissions are still enforced correctly in Queries

Looks good!

@pashiav
pashiav merged commit 8c09cd5 into issue-6571 Jul 16, 2025
14 checks passed
@pashiav
pashiav deleted the issue-6615 branch July 16, 2025 15:47
@github-project-automation github-project-automation Bot moved this from 📋Back Log to ✅Done in General Tester Board Jul 16, 2025
@CarolineDenis CarolineDenis modified the milestones: 7.12.0, 7.11.2 Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅Done

Development

Successfully merging this pull request may close these issues.

Reorganize permissions app under backend/permissions/

4 participants