Skip to content

Allow to select formatter in field schema config#6255

Merged
CarolineDenis merged 3 commits into
productionfrom
issue-6250
Mar 10, 2025
Merged

Allow to select formatter in field schema config#6255
CarolineDenis merged 3 commits into
productionfrom
issue-6250

Conversation

@CarolineDenis

Copy link
Copy Markdown
Contributor

Fixes #6250

Checklist

  • Self-review the PR after opening it to make sure the changes look good and
    self-explanatory (or properly documented)
  • Add relevant issue to release milestone

Testing instructions

  • Go to Schema Config -> Any table
  • Under Field Format, select "Formatted"
  • Verify it gets selected

@CarolineDenis CarolineDenis added this to the 7.10.2 milestone Feb 18, 2025
@CarolineDenis
CarolineDenis requested a review from a team February 21, 2025 16:12
@lexiclevenger

Copy link
Copy Markdown
Collaborator

Is the schema config supposed to automatically pick a formatter that is configured for the selected field? This seems to happen in production but not this branch.

Production

Screen.Recording.2025-02-21.at.11.46.12.AM.mov

This branch:

Screen.Recording.2025-02-21.at.11.55.02.AM.mov

@CarolineDenis

Copy link
Copy Markdown
Contributor Author

@lexiclevenger, good catch

@lexiclevenger lexiclevenger left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Verify it gets selected

Looks good, the issue from my previous comment is resolved!

@CarolineDenis
CarolineDenis requested review from a team and acwhite211 February 24, 2025 14:18

@emenslin emenslin left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Verify it gets selected

Looks good

@CarolineDenis
CarolineDenis merged commit e3671b8 into production Mar 10, 2025
@CarolineDenis
CarolineDenis deleted the issue-6250 branch March 10, 2025 13:47
@github-project-automation github-project-automation Bot moved this from 📋Back Log to ✅Done in General Tester Board Mar 10, 2025
@specifysoftware

Copy link
Copy Markdown

This pull request has been mentioned on Specify Community Forum. There might be relevant details there:

https://discourse.specifysoftware.org/t/specify-7-10-2-release-announcement/2455/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅Done

Development

Successfully merging this pull request may close these issues.

"Formatted" Field Format Not Auto-Selecting

6 participants