Only create remote to-one resources after object is created#6147
Merged
Conversation
pashiav
approved these changes
Jan 23, 2025
Contributor
There was a problem hiding this comment.
- Ensure the COJO is properly set on the CO/COG
- Immediately after the save button is pressed
- After the page is refreshed
- Go to the Parent Cog of the CO or COG and ensure the newly added child correctly appears in the COGs children
- Remove the COJO from the CO/COG form and save the CO/COG: ensure the COJO is properly set on the CO/COG
- Immediately after the save button is pressed
- After the page is refreshed
- Ensure that both new and existing children can be added to a COG
Looks good - working as expected!
Note: noticed that when adding/deleting a COJO from a CO, it appears that there are two duplicate records in the navigator (consistently reproduced).
Issue made: #6149
CarolineDenis
approved these changes
Jan 23, 2025
emenslin
approved these changes
Jan 23, 2025
emenslin
left a comment
Collaborator
There was a problem hiding this comment.
- Ensure the COJO is properly set on the CO/COG
- Go to the Parent Cog of the CO or COG and ensure the newly added child correctly appears in the COGs children
- Remove the COJO from the CO/COG form and save the CO/COG: ensure the COJO is properly set on the CO/COG
- Ensure that both new and existing children can be added to a COG
Checked on both the CO and COG form and didn't run into any issues aside from what Pashia mentioned.
lexiclevenger
approved these changes
Jan 23, 2025
lexiclevenger
left a comment
Collaborator
There was a problem hiding this comment.
Testing instructions
- On either the CollectionObject (CO) or CollectionObjectGroup (COG) form, add a CollectionObjectGroupJoin (COJO) via the
cojorelationship - Save the CO/COG
- Ensure the COJO is properly set on the CO/COG
- Immediately after the save button is pressed
- After the page is refreshed
- Go to the Parent Cog of the CO or COG and ensure the newly added child correctly appears in the COGs children
- Remove the COJO from the CO/COG form and save the CO/COG: ensure the COJO is properly set on the CO/COG
- Immediately after the save button is pressed
- After the page is refreshed
- Ensure that both new and existing children can be added to a COG
Looks good to me, too!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6139
From #6139 (comment)
Checklist
self-explanatory (or properly documented)
Testing instructions
cojorelationship