Apply COG sibling logic to loan returns

[acwhite211]

Fixes #5501

Extend the COG sibling relationship logic from loans to loan returns. So, when a loan return is added, there will also be loan returns created for it's siblings.

The complication with the return counts is handled in the following ways:

• If the original loan return has all the items returned/resolved, then the new loan return should have all the items returned/resolved.
• If the original loan return has zero the items returned/resolved, then the new loan return should have zero the items returned/resolved.
• Otherwise, just match the quantity returned/resolved to the original loan return, in the case of a partial return, but don't exceed the loan prep quantity.

Checklist

• Self-review the PR after opening it to make sure the changes look good and
  self-explanatory (or properly documented)
• Add relevant issue to release milestone

Testing instructions

• Create a new consolidated COG. Go to http://localhost/specify/view/collectionobjectgroup/new/, set the name, then set the cogType to consolidated. Save.
• Add a new child CO with a new prep. Set the count to 2.
• Repeat: Add a new child CO with a new prep. Set the count to 2.
• Save.
• Create a new loan, use the catalog numbers from the new COs so that both of the new preps are in the loan preps.
• Set the loan number to something random.
• Save.
• Click 'Return Loan'.
• Select the first loan prep only. Set the quantity returned and quantity resolved to 1.
• Save.
• Refresh page.
• See that both of the loan preps have been fully returned. See that the quantity returned and quantity resolved are both 2.
• Verify that the behavior for prep CO that are not a part of consolidated COG is the same as before.

==> The purpose of these tests is to verify that the count returned is set to the maximum, whatever the number entered by the user + verify that all siblings of a prep CO that is a part of a consolidated COG are also returned to they max.

[alesan99]

• See that both of the loan preps have been fully returned. See that the quantity returned and quantity resolved are both 2.
• Verify that the behavior for prep CO that are not a part of consolidated COG is the same as before.

---

If I'm understanding correctly, I believe something is wrong here?

I returned the 2nd prep with quantity and quantity resolved set to 1.
The values were maxed out to 2 for the 1st prep, but not the 2nd.

[acwhite211]

@alesan99 Thanks, I'll check it out. After refreshing the page, the quantity returned and quantity resolved should both be 2.

[pashiav]

• See that both of the loan preps have been fully returned. See that the quantity returned and quantity resolved are both 2.
• Verify that the behavior for prep CO that are not a part of consolidated COG is the same as before.

---

(I tried 2 preps and 6 preps following the same directions)

When testing 2 preps, I had the same behavior as #6038 (review).

When testing 6 preps, only one loan prep was fully returned. The other prep only had 1 prep fully returned.

[acwhite211]

@pashiav @alesan99 That issue with the counts should be fixed now 😀

[alesan99]

That fixed it!

Also tried it with >2 preps, with varying counts per prep, and with partial loans. It properly recognizes the maximums those cases too 👍

[emenslin]

• See that both of the loan preps have been fully returned. See that the quantity returned and quantity resolved are both 2.
• Verify that the behavior for prep CO that are not a part of consolidated COG is the same as before.

Returning consolidated loan preps sometimes triggers unload protect

cZCYCm4uCt.mp4

Preparations that are not part of a nonconsolidated COG also return the full amount even if you only select 1, is this the intended behavior?

lF9FLhEuJF.mp4

[acwhite211]

@emenslin Good catch. Pushed a commit that should fix it so that loan preps not in consolidated preps can still be partially returned.

[acwhite211]

Returning consolidated loan preps sometimes triggers unload protect

This might be because the counts get modified in the back-end without the front-end knowing, so it thinks there are changes that need to be saved. It seems that the loan return preps are being saved properly. After pressing the save button again, the save button is greyed out, like it should be. This isn't a major issue, so I think we'll be ok with this behavior for now.

[emenslin]

Are we sure this behavior is okay and wouldn't be confusing considering this doesn't happen anywhere else?

[acwhite211]

@pashiav Thanks, looks like the fix I made only avoided that error on the Loan form and not on the CO form. Just pushed a fix.

@specify/ux-testing @pashiav @emenslin good for re-review 😀

[pashiav]

• See that both of the loan preps have been fully returned. See that the quantity returned and quantity resolved are both 2.
• Verify that the behavior for prep CO that are not a part of consolidated COG is the same as before.

---

#6038 (review) fixed!

#6038 (review) still occurs:

'Is resolved' is checked when the preparation is only partially resolved, the box should only be checked when the full amount of preps have been resolved

https://ciscollections21524gen-issue-5501.test.specifysystems.org/specify/view/loan/253/

[acwhite211]

@pashiav Thanks, the isresolved logic should work now for both consolidated and unconsolidated cogs. Sorry I didn't catch that sooner.

[emenslin]

• See that both of the loan preps have been fully returned. See that the quantity returned and quantity resolved are both 2.
• Verify that the behavior for prep CO that are not a part of consolidated COG is the same as before.

Is Resolved issue is fixed, however, I could be wrong but I thought the ability to search COGs was removed from this pr? I just want to make sure this is supposed to be implemented here before approving

[CarolineDenis]

@emenslin, indeed it is supposed to be removed

[emenslin]

• See that both of the loan preps have been fully returned. See that the quantity returned and quantity resolved are both 2.
• Verify that the behavior for prep CO that are not a part of consolidated COG is the same as before.

Searching for COGS was removed, looks good

[pashiav]

• See that both of the loan preps have been fully returned. See that the quantity returned and quantity resolved are both 2.
• Verify that the behavior for prep CO that are not a part of consolidated COG is the same as before.

---

Looks good! Working as expected.