Skip to content

Add a way to explicity choose aggregators in QB#4646

Merged
CarolineDenis merged 14 commits into
productionfrom
issue-4620
May 21, 2024
Merged

Add a way to explicity choose aggregators in QB#4646
CarolineDenis merged 14 commits into
productionfrom
issue-4620

Conversation

@CarolineDenis

@CarolineDenis CarolineDenis commented Mar 13, 2024

Copy link
Copy Markdown
Contributor

Fixes #4620

Checklist

  • Self-review the PR after opening it to make sure the changes look good
    and self-explanatory (or properly documented)
  • Add relevant issue to release milestone

Testing instructions

  • Navigate to the Query Builder (QB).

  • Select a table that you know has one or several aggregators (To check, go to app resources, navigate to Record Formatter, choose the table, select aggregator tab, and verify the list of aggregators names available).

  • Choose "aggregated."

  • Verify that in the query line, after selecting the "aggregated" field box, a drop-down appears with a list of aggregators choices (corresponding to the list in app resources).

Verify that changing the aggregator changes the way the field is displayed in the results table.

@CarolineDenis CarolineDenis modified the milestones: 7.9.4, 7.9.5 Mar 13, 2024
@CarolineDenis CarolineDenis modified the milestones: 7.9.5, 7.9.6 Mar 13, 2024
@acwhite211

acwhite211 commented Mar 15, 2024

Copy link
Copy Markdown
Collaborator

The problem seems to be that the back-end is ignoring the formatter name in the request. It is just getting the aggragator and then getting the formatter that the aggregator is pointing to. I changed the code so that it takes into account the 'formatter name' that is passed in the query builder request.

@acwhite211 acwhite211 added the 2 - Queries Issues that are related to the query builder or queries in general label Mar 15, 2024
@acwhite211 acwhite211 self-assigned this Mar 15, 2024
Comment thread specifyweb/frontend/js_src/lib/components/QueryBuilder/Line.tsx Outdated
@CarolineDenis
CarolineDenis requested review from a team and removed request for bronwyncombs, emenslin, grantfitzsimmons and melton-jason March 20, 2024 18:42

@emenslin emenslin left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing instructions

  • Navigate to the Query Builder (QB).

  • Select a table that you know has one or several aggregators (To check, go to app resources, navigate to Record Formatter, choose the table, select aggressors tab, and verify the list of aggregators names available).

  • Choose "aggregated."

  • Verify that in the query line, after selecting the "aggregated" field box, a drop-down appears with a list of aggregators choices (corresponding to the list in app resources).

  • Verify that changing the aggregator changes the way the field is displayed in the results table.

Changing the aggregator does not change the way the field is displayed and seems to only show the default aggregation.

xOcI2oigeF.mp4

@CarolineDenis
CarolineDenis requested review from a team and emenslin May 8, 2024 15:45

@emenslin emenslin left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing instructions

  • Navigate to the Query Builder (QB).

  • Select a table that you know has one or several aggregators (To check, go to app resources, navigate to Record Formatter, choose the table, select aggregator tab, and verify the list of aggregators names available).

  • Choose "aggregated."

  • Verify that in the query line, after selecting the "aggregated" field box, a drop-down appears with a list of aggregators choices (corresponding to the list in app resources).

  • Verify that changing the aggregator changes the way the field is displayed in the results table.

Looks good, changing the aggregator changes the results now!

RsLlzzdhIV.mp4

@emenslin
emenslin requested a review from a team May 8, 2024 16:57

@alesan99 alesan99 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Verify that in the query line, after selecting the "aggregated" field box, a drop-down appears with a list of aggregators choices (corresponding to the list in app resources).

Added new aggregators and it looks good, & changes are reflected in Query results

chrome_8GE0d2wOxq

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 - Queries Issues that are related to the query builder or queries in general

Projects

Status: ✅Done

Development

Successfully merging this pull request may close these issues.

Add support for explicitly choosing an aggregator in Query Builder

5 participants