You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This code conditionally renders a QueryFieldFormatter component based on the fieldMeta properties. If fieldType is either 'formatter' or 'aggregator' and tableName is a string, it displays the QueryFieldFormatter component with specific props like formatter, tableName, type, and onChange.
Theoretically it already should support this for aggregators, but either due to a bug in the existing code or an oversight, this is not functional at the moment.
This indicates to me that the intention was to have this existing feature request cover aggregators as well (as the logic should be nearly identical).
Expected Behavior
When adding an (aggregated) line to a query, the user should be able to explicitly define which aggregation to use
The gear icon should only appear to the right of the (aggregated) line if there are two or more aggregators configured for that table
This is arguably a bug in the existing implementation, but because it is not functional and outside the scope of the previous issue, I have opened this one. I do see this as one and the same as #1959 at its core.
The feature request "Add support for explicitly choosing a formatter in Query Builder" (#1959) did not cover choosing an aggregator.
@maxpatiiuk said in this comment that at one point it was
This code conditionally renders a
QueryFieldFormattercomponent based on thefieldMetaproperties. IffieldTypeis either 'formatter' or 'aggregator' andtableNameis a string, it displays theQueryFieldFormattercomponent with specific props likeformatter,tableName,type, andonChange.Theoretically it already should support this for aggregators, but either due to a bug in the existing code or an oversight, this is not functional at the moment.
This indicates to me that the intention was to have this existing feature request cover aggregators as well (as the logic should be nearly identical).
Expected Behavior
(aggregated)line to a query, the user should be able to explicitly define which aggregation to use(aggregated)line if there are two or more aggregators configured for that tableThis is arguably a bug in the existing implementation, but because it is not functional and outside the scope of the previous issue, I have opened this one. I do see this as one and the same as #1959 at its core.