Skip to content

Change smallBtn background color when hover to saveBtn color#3543

Merged
CarolineDenis merged 5 commits into
productionfrom
issue-3535
Jun 1, 2023
Merged

Change smallBtn background color when hover to saveBtn color#3543
CarolineDenis merged 5 commits into
productionfrom
issue-3535

Conversation

@CarolineDenis

@CarolineDenis CarolineDenis commented May 30, 2023

Copy link
Copy Markdown
Contributor

Fixes #3535

@CarolineDenis
CarolineDenis requested a review from a team May 30, 2023 16:17
@CarolineDenis CarolineDenis changed the title Change smallBtn background color when hover to saveBtn Change smallBtn background color when hover to saveBtn color May 30, 2023
carlosmbe
carlosmbe suggested changes May 30, 2023
View reviewed changes

@carlosmbe carlosmbe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too bright in dark mode
New Version
Screenshot 2023-05-30 at 1 58 52 PM

Original
Screenshot 2023-05-30 at 1 59 21 PM

melton-jason
melton-jason requested changes May 30, 2023
View reviewed changes
Comment thread specifyweb/frontend/js_src/lib/components/Atoms/className.ts Outdated
@CarolineDenis

CarolineDenis commented May 30, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@melton-jason @carlosmbe
After discussion with @grantfitzsimmons we decided to unify the behavior for all the Button.Small. The background when hovering will be a darker grey in light mode and lighter grey in dark mode. See videos bellow.

btns.mov
Screen.Recording.2023-05-30.at.3.05.36.PM.mov

@melton-jason

melton-jason commented May 30, 2023

Copy link
Copy Markdown
Contributor

After discussion with @grantfitzsimmons we decided to unify the behavior for all the Button.Small. The background when hovering will be a darker grey in both modes.

That works for me, as long as there is a consensus 👍

carlosmbe
carlosmbe approved these changes May 31, 2023
View reviewed changes

@carlosmbe carlosmbe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good 👍

@CarolineDenis
CarolineDenis merged commit de940f0 into production Jun 1, 2023
@CarolineDenis
CarolineDenis deleted the issue-3535 branch June 1, 2023 13:07
@bronwyncombs

bronwyncombs commented Jun 5, 2023

Copy link
Copy Markdown

v7.8.12-prerelease: Button.Small works as expected

@carlosmbe carlosmbe mentioned this pull request Jun 5, 2023
Merged
@specifysoftware

specifysoftware commented Jun 13, 2023

Copy link
Copy Markdown

This pull request has been mentioned on Specify Community Forum. There might be relevant details there:

https://discourse.specifysoftware.org/t/specify-7-8-12-release-announcement/1202/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@melton-jason melton-jason melton-jason approved these changes
+1 more reviewer
@carlosmbe carlosmbe carlosmbe approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Button highlighting is the wrong color

5 participants

@CarolineDenis @melton-jason @bronwyncombs @specifysoftware @carlosmbe