[SofaMeshCollision] Fix TriangleModel to handle topology changes#903
Merged
damienmarchal merged 11 commits intosofa-framework:masterfrom Feb 13, 2019
Merged
[SofaMeshCollision] Fix TriangleModel to handle topology changes#903damienmarchal merged 11 commits intosofa-framework:masterfrom
damienmarchal merged 11 commits intosofa-framework:masterfrom
Conversation
…gleModel. As this class use directly the topology buffers, no need neither for TopologyData. Just check the topology revision and update the component if topology has changed.
Contributor
Author
|
[ci-build][with-all-tests] |
…te mesh component when revision has changed.
…triangle buffer and *buffer
…error if no topology is provided.
…s mixing quads and triangles.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix crash when removing triangles in scene using TriangleModel component.
Clean and comment the class while undusting it (sorry hard to read the diff)
This PR:
Reviewers will merge only if all these checks are true.