Skip to content

[SofaCUDA] Apply new factory registration mechanism#5827

Merged
fredroy merged 7 commits intosofa-framework:masterfrom
hugtalbot:202512_registration_mechanism_SofaCUDA
Jan 28, 2026
Merged

[SofaCUDA] Apply new factory registration mechanism#5827
fredroy merged 7 commits intosofa-framework:masterfrom
hugtalbot:202512_registration_mechanism_SofaCUDA

Conversation

@hugtalbot
Copy link
Copy Markdown
Contributor

@hugtalbot hugtalbot commented Dec 12, 2025

Closes Refactor object registration

This should be the last PR related to #4429 😅


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@hugtalbot hugtalbot added this to the v26.06 milestone Dec 12, 2025
@hugtalbot hugtalbot added pr: status to review To notify reviewers to review this pull-request refactoring Refactor code labels Dec 12, 2025
@hugtalbot
Copy link
Copy Markdown
Contributor Author

[ci-build]

@hugtalbot hugtalbot moved this to In progress in Refactor object registration Dec 17, 2025
@fredroy fredroy force-pushed the 202512_registration_mechanism_SofaCUDA branch from 436c784 to bdb34cf Compare January 5, 2026 00:42
@hugtalbot hugtalbot added pr: status wip Development in the pull-request is still in progress pr: status to review To notify reviewers to review this pull-request and removed pr: status to review To notify reviewers to review this pull-request pr: status wip Development in the pull-request is still in progress labels Jan 13, 2026
@fredroy fredroy force-pushed the 202512_registration_mechanism_SofaCUDA branch 3 times, most recently from ecfb6d0 to 5d732fc Compare January 19, 2026 01:43
@fredroy fredroy added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Jan 19, 2026
@hugtalbot
Copy link
Copy Markdown
Contributor Author

❤️

@fredroy fredroy force-pushed the 202512_registration_mechanism_SofaCUDA branch from 5d732fc to a4ef80e Compare January 20, 2026 05:36
@fredroy fredroy added pr: status to review To notify reviewers to review this pull-request and removed pr: status ready Approved a pull-request, ready to be squashed labels Jan 20, 2026
@fredroy
Copy link
Copy Markdown
Contributor

fredroy commented Jan 20, 2026

❤️

@hugtalbot

I reverted the "ready" status, it seems not compiling for gcc in the SofaCUDA plugin.
(I say "seems" because with 25k lines of build lines, I cannot find the error itself 🙃)

@hugtalbot hugtalbot requested a review from fredroy January 23, 2026 10:04
@fredroy fredroy force-pushed the 202512_registration_mechanism_SofaCUDA branch from a4ef80e to 4c1a44a Compare January 27, 2026 23:08
@fredroy
Copy link
Copy Markdown
Contributor

fredroy commented Jan 27, 2026

[ci-build][with-all-tests]

@fredroy fredroy added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Jan 28, 2026
@fredroy fredroy force-pushed the 202512_registration_mechanism_SofaCUDA branch from 4c1a44a to 883548a Compare January 28, 2026 23:09
@fredroy fredroy merged commit 98d49cf into sofa-framework:master Jan 28, 2026
12 of 13 checks passed
@github-project-automation github-project-automation Bot moved this from In progress to Done in Refactor object registration Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: status ready Approved a pull-request, ready to be squashed refactoring Refactor code

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants