[Core,Helper] Prevent to create objects from unloaded plugins#4722
Merged
Conversation
bakpaul
reviewed
May 7, 2024
Contributor
|
To be discussed at the STC. |
a5df816 to
e6c549a
Compare
Contributor
Author
|
[ci-build][with-all-tests] |
hugtalbot
reviewed
Jul 29, 2024
Contributor
|
else it looks good to me |
f53cff4 to
904f8eb
Compare
904f8eb to
e439798
Compare
Contributor
|
[ci-build][with-all-tests] |
Contributor
|
Tests are fixed, ready then 👮 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a plugin is loaded, the ObjectFactory is populated of Components from this plugin. However, when this plugin is "unloaded", it was still possible to create a component from the plugin. This PR detects that the ObjectFactory tries to instantiate an object that is from an unloaded plugin.
It is particularly useful when the initialization of the plugin fails (SofaCUDA for example). When the initialization fails, the plugin is unloaded.
A unit test is provided
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if