Skip to content

[all] Update code regarding lifecycle in Topology.h#4065

Merged
fredroy merged 7 commits into
sofa-framework:masterfrom
hugtalbot:202307_update_topology_lifecycle
Sep 13, 2023
Merged

[all] Update code regarding lifecycle in Topology.h#4065
fredroy merged 7 commits into
sofa-framework:masterfrom
hugtalbot:202307_update_topology_lifecycle

Conversation

@hugtalbot

@hugtalbot hugtalbot commented Jul 21, 2023

Copy link
Copy Markdown
Contributor

Wait for #4058 to be merged to solve the failure

[ci-depends-on https://github.com/sofa-framework/ManifoldTopologies/pull/7]


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@hugtalbot hugtalbot added pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code labels Jul 21, 2023
@hugtalbot hugtalbot requested a review from epernod July 21, 2023 20:56
@hugtalbot

Copy link
Copy Markdown
Contributor Author

[ci-build][with-all-tests]

@sofabot

sofabot commented Jul 23, 2023

Copy link
Copy Markdown
Collaborator

[ci-depends-on] detected during build #2.

To unlock the merge button, you must

@hugtalbot

Copy link
Copy Markdown
Contributor Author

The error on the CI :

J:\0\src\applications\plugins\SofaCUDA\sofa/gpu/cuda/CudaSphereModel.h(26): error: This header has been DISABLED since v23.12 after being deprecated on v23.06. To fix this error you must include SofaCUDA/component/collision/geometry/CudaSphereModel.h instead. 
J:\0\src\applications\plugins\SofaCUDA\sofa/gpu/cuda/CudaPointModel.h(26): error: This header has been DISABLED since v23.12 after being deprecated on v23.06. To fix this error you must include SofaCUDA/component/collision/geometry/CudaPointModel.h instead. 

has been fixed in the PR suite Lifecycle.
This will should therefore be automatically be fixed when #4058 will be merged

@sofabot

sofabot commented Sep 11, 2023

Copy link
Copy Markdown
Collaborator

[ci-depends-on] detected during build #3.

To unlock the merge button, you must

@fredroy

fredroy commented Sep 12, 2023

Copy link
Copy Markdown
Contributor

[ci-build][with-all-tests]

@sofabot

sofabot commented Sep 12, 2023

Copy link
Copy Markdown
Collaborator

[ci-depends-on] detected during build #4.

To unlock the merge button, you must

@fredroy

fredroy commented Sep 13, 2023

Copy link
Copy Markdown
Contributor

[ci-build][with-all-tests][force-full-build]

@sofabot

sofabot commented Sep 13, 2023

Copy link
Copy Markdown
Collaborator

[ci-depends-on] detected during build #5.

All dependencies are merged/closed and all ExternalProject pointers are up-to-date. Congrats! 👍

@fredroy fredroy added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Sep 13, 2023
@fredroy fredroy merged commit 0057c86 into sofa-framework:master Sep 13, 2023
@hugtalbot hugtalbot added this to the v23.12 milestone Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: clean Cleaning the code pr: status ready Approved a pull-request, ready to be squashed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants