[all] Use NVI design pattern for drawVisual

[damienmarchal]

Actually what we called "delegate" pattern (the one we used to think about to fix the "call-super" anti-pattern) is often refereed on intenret as Non Virtual Interface (a pattern very similar to the Template Method Pattern).

Here is a attempt to see it in use on VisualModel::drawVisual;

---

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

---

Reviewers will merge this pull-request only if

• it builds with SUCCESS for all platforms on the CI.
• it does not generate new warnings.
• it does not generate new unit test failures.
• it does not generate new scene test failures.
• it does not break API compatibility.
• it is more than 1 week old (or has fast-merge label).

[damienmarchal]

@alxbilger thank for the review.

[damienmarchal]

Do everyone agrees on having the conditions I moved up into the NVI VisualModel::drawVisual() and with the one I added into the VisualVisitor ?

Eg:

void VisualModel::drawVisual(const VisualParams* vparams)
{
    // don't draw if specified not to do so in the user interface
    if (!vparams->displayFlags().getShowVisualModels())
        return;

    // don't draw if the component is not in valid state (we can change the condition so Loading/Unknow states are drawn differently) 
    if( d_componentState.getValue() == sofa::core::objectmodel::ComponentState::Invalid )
        return;

    // don't draw if this component is specifically configured to be disabled (It is questionnable to have a data for that). 
    // having a d_enable on Base would be better. 
    if (!d_draw.getValue())
        return;

    // RAI to be sure the states changed during the rendering don't leaks 
    const auto stateLifeCycle = vparams->drawTool()->makeStateLifeCycle();

    doDrawVisual(vparams);
}

[alxbilger]

[ci-build][with-all-tests]

[damienmarchal]

CI passed...

[alxbilger]

Now that you have renamed d_draw into d_enable, you need to deprecate d_draw in the derived classes instead of removing them.

[hugtalbot]

It should be :

Suggested change

	if( d_componentState.getValue() == sofa::core::objectmodel::ComponentState::Invalid )
	return;
	if( !this->isComponentStateValid() )
	return;

However, this will invalidate all components which do not support their componentState

[damienmarchal]

So ? It looks like you are making a suggestion of change but saying it will not work the same.

[alxbilger]

[ci-build][with-all-tests]